Skip to content

ci: Update circleci config to correctly run mv3 e2e tests#24704

Merged
danjm merged 2 commits intodevelopfrom
update-circle-ci-config
May 22, 2024
Merged

ci: Update circleci config to correctly run mv3 e2e tests#24704
danjm merged 2 commits intodevelopfrom
update-circle-ci-config

Conversation

@danjm
Copy link
Copy Markdown
Contributor

@danjm danjm commented May 22, 2024 •
edited by github-actions bot
Loading

Description

This ensures that ENABLE_MV3=true is correctly set for all tests run within the test-e2e-chrome-mv3 job, and it ensures test results are stored on circleci (in the case of failures).

Open in GitHub Codespaces

Manual testing steps

When grouped with all the other e2e fixes, e2e tests should pass. [TODO: add list of all PRs here]

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@danjm danjm requested review from a team and kumavis as code owners May 22, 2024 09:24
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 22, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label May 22, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented May 22, 2024

Builds ready [764f0dc]
Page Load Metrics (1178 ± 596 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint601881084120
domContentLoaded95319136
load48303611781241596
domInteractive95319136
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

DDDDDanica
DDDDDanica reviewed May 22, 2024
View reviewed changes
@seaona
Copy link
Copy Markdown
Member

seaona commented May 22, 2024

I see this when I click on some of the jobs 🤔

  • test-e2e-chrome
  • test-e2e-chrome-mv3

Screenshot from 2024-05-22 12-52-08

@danjm
Copy link
Copy Markdown
Contributor Author

danjm commented May 22, 2024

@seaona If I go to one of the urls in your screenshot, e.g. https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/jobs/2904570, I am successfully redirected to https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/81699/workflows/3f6e353f-6194-4dd1-a5ee-6e33774128cb/jobs/2904570

Is the problem still occuring for you?

chloeYue
chloeYue approved these changes May 22, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@chloeYue chloeYue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chloeYue
Copy link
Copy Markdown
Contributor

chloeYue commented May 22, 2024

@seaona If I go to one of the urls in your screenshot, e.g. https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/jobs/2904570, I am successfully redirected to https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/81699/workflows/3f6e353f-6194-4dd1-a5ee-6e33774128cb/jobs/2904570

Is the problem still occuring for you?

I see this when I click on some of the jobs 🤔

  • test-e2e-chrome
  • test-e2e-chrome-mv3

Screenshot from 2024-05-22 12-52-08

I see this when I click on some of the jobs 🤔

  • test-e2e-chrome
  • test-e2e-chrome-mv3

Screenshot from 2024-05-22 12-52-08

hm...i can open the links

@danjm danjm changed the title Update circleci config to correctly run mv3 e2e tests ci: Update circleci config to correctly run mv3 e2e tests May 22, 2024
@danjm danjm added the team-extension-platform Extension Platform team label May 22, 2024
@chloeYue
Copy link
Copy Markdown
Contributor

chloeYue commented May 22, 2024

Hi @danjm, in test-e2e-chrome-mv3 job, we store much more artifacts than other jobs, is this intended?
Screenshot 2024-05-22 at 14 02 07

@seaona
Copy link
Copy Markdown
Member

seaona commented May 22, 2024 •
edited
Loading

Is the problem still occuring for you?

I've refreshed and now the job links are working for me 👍

[Edit] as Chloe mentions above, I also see lots of artifacts which are not related to test failures 🤔 maybe this needs to be looked separately?

@DDDDDanica
Copy link
Copy Markdown
Contributor

DDDDDanica commented May 22, 2024

Is the problem still occuring for you?

I've refreshed and now the job links are working for me 👍

[Edit] as Chloe mentions above, I also see lots of artifacts which are not related to test failures 🤔 maybe this needs to be looked separately?

Hey @seaona this should be fixed in this merged PR :)
#24696

@danjm
Copy link
Copy Markdown
Contributor Author

danjm commented May 22, 2024

The problem with all the extra artifacts was actually solved by #24696

So if we just update this branch, those extra artifacts should go away

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented May 22, 2024

Builds ready [07f364e]
Page Load Metrics (1001 ± 556 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint63163972914
domContentLoaded95616115
load51311910011158556
domInteractive95616115
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@danjm
Copy link
Copy Markdown
Contributor Author

danjm commented May 22, 2024

@chloeYue the artifacts look better now:

Screenshot from 2024-05-22 13-43-03

@danjm danjm merged commit 3ae9836 into develop May 22, 2024
@danjm danjm deleted the update-circle-ci-config branch May 22, 2024 16:16
@github-actions github-actions bot locked and limited conversation to collaborators May 22, 2024
@metamaskbot metamaskbot added release-11.16.6 Issue or pull request that will be included in release 11.16.6 and removed release-11.18.0 labels Jun 4, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jun 4, 2024

Missing release label release-11.16.6 on PR. Adding release label release-11.16.6 on PR and removing other release labels(release-11.18.0), as PR was cherry-picked in branch 11.16.6.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DDDDDanica DDDDDanica DDDDDanica approved these changes

@chloeYue chloeYue chloeYue approved these changes

@kumavis kumavis Awaiting requested review from kumavis kumavis is a code owner

Assignees

No one assigned

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template release-11.16.6 Issue or pull request that will be included in release 11.16.6 team-extension-platform Extension Platform team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@danjm @metamaskbot @seaona @chloeYue @DDDDDanica