Description

"The user data directory contains profile data such as history, bookmarks, and cookies, as well as other per-installation local state."

We are using the user-data-dir command and unnecessarily caching such data in the test-artefacts/ directory. With local testing, and seemingly with test run as part of the same job on CI, it can be seen that this cached data has persistence between test runs, and can thereby cause flakiness. Locally, it seems that old builds of the extension can be cached. On CI, it seems that things like our fetch cache can be persisted between browser sessions.

I do not believe this is actually used for any purpose, and we can reduce flakiness by removing it.

Manual testing steps

all e2e tests should pass

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.