fix: Prevent legacy <UnconnectedAccountAlert/> component from displaying#24475
Merged
fix: Prevent legacy <UnconnectedAccountAlert/> component from displaying#24475
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
vthomas13
approved these changes
May 10, 2024
jonybur
approved these changes
May 10, 2024
Collaborator
Builds ready [c0f546a]
Page Load Metrics (470 ± 460 ms)
Bundle size diffs
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #24475 +/- ##
========================================
Coverage 67.45% 67.45%
========================================
Files 1288 1288
Lines 50149 50146 -3
Branches 13008 13007 -1
========================================
- Hits 33824 33822 -2
+ Misses 16325 16324 -1 ☔ View full report in Codecov by Sentry. |
Collaborator
|
Missing release label release-11.17.0 on PR. Adding release label release-11.17.0 on PR and removing other release labels(release-11.18.0), as PR was added to branch 11.17.0 when release was cut. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the PR to release Multichain v1 (#24362) we didn't prevent the legacy
<UnconnectedAccountAlert/>from displaying, which is problematic -- it overlays the toast and isn't desired. This PR prevents that legacy component from ever displaying.Related issues
Fixes: N/A
Manual testing steps
<UnconnectedAccountAlert/>componentScreenshots/Recordings
Before
See the old component
After
See only the toast
Pre-merge author checklist
Pre-merge reviewer checklist