feat: Removed multichain flag for v1 release#24362
Merged
Conversation
ustad56
approved these changes
May 3, 2024
Contributor
|
@NidhiKJha you have 1 broken unit test |
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
|
I'm not sure if 'Select networks for each site' in Experimental settings should be ON by default? noFlag.mov |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #24362 +/- ##
===========================================
+ Coverage 67.37% 67.45% +0.08%
===========================================
Files 1286 1286
Lines 50114 50077 -37
Branches 13004 12985 -19
===========================================
+ Hits 33761 33777 +16
+ Misses 16353 16300 -53 ☔ View full report in Codecov by Sentry. |
Collaborator
Builds ready [3f07521]
Page Load Metrics (944 ± 636 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [ef8a63d]
Page Load Metrics (659 ± 494 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
darkwing
approved these changes
May 8, 2024
jpuri
approved these changes
May 9, 2024
Contributor
jpuri
left a comment
There was a problem hiding this comment.
I reviewed the code owned by confirmations team in the PR, code changes look good to me.
Collaborator
|
Missing release label release-11.17.0 on PR. Adding release label release-11.17.0 on PR and removing other release labels(release-11.18.0), as PR was added to branch 11.17.0 when release was cut. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to remove all the Multichain flags from code except the send and swap flow
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2431
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist