Skip to content

chore: nonsense!#24301

Closed
davidmurdoch wants to merge 6 commits intodevelopfrom
nonsense-change-testing
Closed

chore: nonsense!#24301
davidmurdoch wants to merge 6 commits intodevelopfrom
nonsense-change-testing

Conversation

@davidmurdoch
Copy link
Copy Markdown
Contributor

@davidmurdoch davidmurdoch commented Apr 29, 2024 •
edited by github-actions bot
Loading

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@davidmurdoch davidmurdoch added the team-extension-platform Extension Platform team label Apr 29, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 29, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@davidmurdoch davidmurdoch changed the title chore: nonsense chore: nonsense! Apr 29, 2024
davidmurdoch
davidmurdoch commented Apr 29, 2024
View reviewed changes
@davidmurdoch davidmurdoch changed the base branch from update-signature-bot to develop April 29, 2024 23:15
@davidmurdoch davidmurdoch changed the base branch from develop to update-signature-bot April 29, 2024 23:15
davidmurdoch
davidmurdoch commented Apr 29, 2024
View reviewed changes
davidmurdoch
davidmurdoch commented Apr 30, 2024
View reviewed changes
davidmurdoch
davidmurdoch commented Apr 30, 2024
View reviewed changes
@davidmurdoch davidmurdoch mentioned this pull request Apr 30, 2024
Merged
@davidmurdoch davidmurdoch added the DO-NOT-MERGE Pull requests that should not be merged label Apr 30, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Apr 30, 2024

Builds ready [7b23abd]
Page Load Metrics (1060 ± 660 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint58179993517
domContentLoaded8311773
load47358310601375660
domInteractive8311773
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.24%. Comparing base (2d413a7) to head (7b23abd).
Report is 3 commits behind head on update-signature-bot.

Additional details and impacted files 
@@                  Coverage Diff                  @@
##           update-signature-bot   #24301   +/-   ##
=====================================================
  Coverage                 67.24%   67.24%           
=====================================================
  Files                      1271     1271           
  Lines                     49623    49623           
  Branches                  12908    12908           
=====================================================
  Hits                      33367    33367           
  Misses                    16256    16256

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from update-signature-bot to develop May 1, 2024 11:04
@Gudahtt
Copy link
Copy Markdown
Member

Gudahtt commented May 1, 2024

Closing, this was just used for testing #24296

@Gudahtt Gudahtt closed this May 1, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2024
@davidmurdoch davidmurdoch deleted the nonsense-change-testing branch August 2, 2024 22:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

DO-NOT-MERGE Pull requests that should not be merged team-extension-platform Extension Platform team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@davidmurdoch @metamaskbot @Gudahtt