Skip to content

ci: update cla-signature-bot#24296

Merged
legobeat merged 4 commits intodevelopfrom
update-signature-bot
May 1, 2024
Merged

ci: update cla-signature-bot#24296
legobeat merged 4 commits intodevelopfrom
update-signature-bot

Conversation

@davidmurdoch
Copy link
Copy Markdown
Contributor

@davidmurdoch davidmurdoch commented Apr 29, 2024 •
edited
Loading

Tested in a separate PR using this PR's branch as it's base, as the CLA Signature Bot action always uses the base branch's action: #24301. Result using v4.0.0: https://github.com/MetaMask/metamask-extension/actions/runs/8897494845/job/24432504782

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 29, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@davidmurdoch davidmurdoch changed the title test new signature bot before releasing a new version of it chore: update cla-signature-bot Apr 29, 2024
@davidmurdoch davidmurdoch added the team-extension-platform Extension Platform team label Apr 29, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Apr 29, 2024

Builds ready [2d413a7]
Page Load Metrics (1116 ± 618 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6112287178
domContentLoaded9491594
load49280411161288618
domInteractive9491594
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.24%. Comparing base (01d6cb9) to head (98dc00c).
Report is 14 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #24296   +/-   ##
========================================
  Coverage    67.24%   67.24%           
========================================
  Files         1271     1271           
  Lines        49623    49623           
  Branches     12908    12908           
========================================
  Hits         33367    33367           
  Misses       16256    16256

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

davidmurdoch
davidmurdoch commented Apr 30, 2024
View reviewed changes
@davidmurdoch davidmurdoch marked this pull request as ready for review April 30, 2024 15:29
@davidmurdoch davidmurdoch requested a review from a team as a code owner April 30, 2024 15:29
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Apr 30, 2024

Builds ready [98dc00c]
Page Load Metrics (1304 ± 664 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6012787178
domContentLoaded9391474
load48337113041382664
domInteractive9391474
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Gudahtt
Gudahtt approved these changes Apr 30, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davidmurdoch davidmurdoch changed the title chore: update cla-signature-bot ci: update cla-signature-bot Apr 30, 2024
@legobeat legobeat merged commit 4b543cd into develop May 1, 2024
@legobeat legobeat deleted the update-signature-bot branch May 1, 2024 11:04
@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2024
@gauthierpetetin gauthierpetetin added the release-12.0.0 Issue or pull request that will be included in release 12.0.0 label Jun 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

+1 more reviewer

@legobeat legobeat legobeat approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-12.0.0 Issue or pull request that will be included in release 12.0.0 team-extension-platform Extension Platform team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@davidmurdoch @metamaskbot @Gudahtt @legobeat @gauthierpetetin