Skip to content

test: [Snaps E2E Test] Create test for snaps UI images#24298

Merged
FrederikBolding merged 4 commits intodevelopfrom
bowen/imagestest
May 1, 2024
Merged

test: [Snaps E2E Test] Create test for snaps UI images#24298
FrederikBolding merged 4 commits intodevelopfrom
bowen/imagestest

Conversation

@bowensanders
Copy link
Copy Markdown
Contributor

@bowensanders bowensanders commented Apr 29, 2024 •
edited
Loading

Description

This test covers images in the snaps UI.

Open in GitHub Codespaces

Related issues

Fixes: #24298

Manual testing steps

  1. Manually execute the E2E test or check CI for completion

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@bowensanders bowensanders added area-snaps team-snaps-platform-deprecated DEPRECATED: please use "team-core-platform" instead (or "team-new-networks" for Solana snap issues) labels Apr 29, 2024
@bowensanders bowensanders self-assigned this Apr 29, 2024
@bowensanders bowensanders requested a review from a team as a code owner April 29, 2024 21:11
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 29, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@bowensanders
Copy link
Copy Markdown
Contributor Author

bowensanders commented Apr 29, 2024

Note: This test avoids changing the privacy snapshot by omitting the "Show Cat" test as it's not an approved data source.

Mrtenz
Mrtenz requested changes Apr 30, 2024
View reviewed changes
@bowensanders bowensanders requested a review from Mrtenz April 30, 2024 17:01
@codecov
Copy link
Copy Markdown

codecov bot commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.28%. Comparing base (60f4c8b) to head (c773a88).
Report is 4 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #24298   +/-   ##
========================================
  Coverage    67.28%   67.28%           
========================================
  Files         1275     1275           
  Lines        49707    49707           
  Branches     12916    12916           
========================================
  Hits         33444    33444           
  Misses       16263    16263

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FrederikBolding FrederikBolding merged commit e5ad8a2 into develop May 1, 2024
@FrederikBolding FrederikBolding deleted the bowen/imagestest branch May 1, 2024 09:25
@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented May 1, 2024

Builds ready [c773a88]
Page Load Metrics (622 ± 538 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint59161862612
domContentLoaded9351363
load4729846221119538
domInteractive9351363
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 31 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@gauthierpetetin gauthierpetetin added the release-12.0.0 Issue or pull request that will be included in release 12.0.0 label Jun 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@FrederikBolding FrederikBolding FrederikBolding approved these changes

@Mrtenz Mrtenz Mrtenz approved these changes

Assignees

@bowensanders bowensanders

Labels

area-snaps release-12.0.0 Issue or pull request that will be included in release 12.0.0 team-snaps-platform-deprecated DEPRECATED: please use "team-core-platform" instead (or "team-new-networks" for Solana snap issues)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bowensanders @metamaskbot @FrederikBolding @Mrtenz @gauthierpetetin