fix: Flaky test to support changes introduced in PR 23155 (#24195)#24206
Merged
danjm merged 1 commit intoVersion-v11.15.0from Apr 23, 2024
Merged
Conversation
## **Description** Change in the PR fixes the flaky test CircleCI job - test-e2e-chrome-vault-decryption https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/77436/workflows/983b4b1c-104a-4acc-ad35-36fe09a03a29/jobs/2685234 [](https://codespaces.new/MetaMask/metamask-extension/pull/24195?quickstart=1) ## **Related issues** Fixes: #24180 #1722 ## **Manual testing steps** Run the test in codespace or locally --> Checkout to the branch yarn yarn dist yarn test:e2e:single test/e2e/vault-decryption-chrome.spec.js --browser=chrome ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## Version-v11.15.0 #24206 +/- ##
=================================================
Coverage 67.55% 67.55%
=================================================
Files 1247 1247
Lines 48934 48934
Branches 12775 12775
=================================================
Hits 33055 33055
Misses 15879 15879 ☔ View full report in Codecov by Sentry. |
Collaborator
Builds ready [e5a0643]
Page Load Metrics (1078 ± 603 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
|
No release label on PR. Adding release label release-11.15.0 on PR, as PR was cherry-picked in branch 11.15.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Cherry pick of this PR #24195