fix: Flaky test to support changes introduced in PR 23155#24195
Merged
hjetpoluru merged 11 commits intodevelopfrom Apr 23, 2024
Merged
fix: Flaky test to support changes introduced in PR 23155#24195hjetpoluru merged 11 commits intodevelopfrom
hjetpoluru merged 11 commits intodevelopfrom
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
pedronfigueiredo
previously approved these changes
Apr 23, 2024
Contributor
|
@hjetpoluru I think it makes more sense to use |
Contributor
Author
|
@HowardBraham Thank you, that actually works and it's faster. Also, I thought that function was only for scroll bars but now I've learned it's for any elements. I am pushing the change. |
Contributor
|
@hjetpoluru I think you don't even need the try/catch now. Have not actually tested myself. |
Contributor
Author
|
@HowardBraham , yes I agree and tested locally. |
Collaborator
Builds ready [0a8596e]
Page Load Metrics (1303 ± 649 ms)
Bundle size diffs
|
pedronfigueiredo
previously approved these changes
Apr 23, 2024
Collaborator
Builds ready [9944376]
Page Load Metrics (1075 ± 596 ms)
Bundle size diffs
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #24195 +/- ##
===========================================
- Coverage 67.56% 67.46% -0.11%
===========================================
Files 1246 1258 +12
Lines 48888 49236 +348
Branches 12746 12818 +72
===========================================
+ Hits 33031 33213 +182
- Misses 15857 16023 +166 ☔ View full report in Codecov by Sentry. |
…tension into fix-flaky-test-1722
HowardBraham
approved these changes
Apr 23, 2024
chloeYue
approved these changes
Apr 23, 2024
Collaborator
Builds ready [42bbee2]
Page Load Metrics (1048 ± 579 ms)
Bundle size diffs
|
Collaborator
|
Missing release label release-11.15.0 on PR. Adding release label release-11.15.0 on PR and removing other release labels(release-11.16.0), as PR was cherry-picked in branch 11.15.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Change in the PR fixes the flaky test CircleCI job - test-e2e-chrome-vault-decryption
https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/77436/workflows/983b4b1c-104a-4acc-ad35-36fe09a03a29/jobs/2685234
Related issues
Fixes:
#24180
#1722
Manual testing steps
Run the test in codespace or locally --> Checkout to the branch
yarn
yarn dist
yarn test:e2e:single test/e2e/vault-decryption-chrome.spec.js --browser=chrome
Pre-merge author checklist
Pre-merge reviewer checklist