feat: Create info component for contract interactions#24131
Merged
pedronfigueiredo merged 5 commits intodevelopfrom Apr 26, 2024
Merged
feat: Create info component for contract interactions#24131pedronfigueiredo merged 5 commits intodevelopfrom
pedronfigueiredo merged 5 commits intodevelopfrom
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
96a3a33 to
1d52390
Compare
5efa7d9 to
052be40
Compare
Collaborator
Builds ready [052be40]
Page Load Metrics (1311 ± 653 ms)
Bundle size diffs
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #24131 +/- ##
========================================
Coverage 67.45% 67.46%
========================================
Files 1258 1259 +1
Lines 49236 49244 +8
Branches 12819 12821 +2
========================================
+ Hits 33212 33218 +6
- Misses 16024 16026 +2 ☔ View full report in Codecov by Sentry. |
052be40 to
358a27a
Compare
2dfd037 to
a8cfcda
Compare
Collaborator
Builds ready [a8cfcda]
Page Load Metrics (1746 ± 595 ms)
Bundle size diffs
|
a8cfcda to
63c2096
Compare
Collaborator
Builds ready [63c2096]
Page Load Metrics (1492 ± 683 ms)
Bundle size diffs
|
63c2096 to
3b61213
Compare
3b61213 to
c8a0adf
Compare
vinistevam
reviewed
Apr 24, 2024
| @@ -13,7 +16,9 @@ type SignatureSecurityAlertResponsesState = { | |||
|
|
|||
| // todo: this component can be deleted once new alert imlementation is added | |||
vinistevam
reviewed
Apr 24, 2024
| title: 'Components/App/Confirm/info/ContractInteractionInfo', | ||
| component: ContractInteractionInfo, | ||
| decorators: [ | ||
| (story: () => any) => <Provider store={store}>{story()}</Provider>, |
Contributor
There was a problem hiding this comment.
Nit: To avoid using any we could cast the Story object: as Meta<typeof ContractInteractionInfo>
vinistevam
approved these changes
Apr 24, 2024
Contributor
vinistevam
left a comment
There was a problem hiding this comment.
Great PR @pedronfigueiredo. Is this component already in use? I'm just asking because we could add some screenshots if not add those from the storybook.
jpuri
approved these changes
Apr 24, 2024
ca38cc1 to
f9f4b7b
Compare
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Updates footer, header and title files to accept transaction confirmations [](https://codespaces.new/MetaMask/metamask-extension/pull/24168?quickstart=1) ## **Related issues** Fixes: #23950 ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
f9f4b7b to
a21b7ab
Compare
Collaborator
Builds ready [a21b7ab]
Page Load Metrics (1344 ± 687 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Contributor
Author
|
@vinistevam Thanks for the comments, I will address them in #24228 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for transactionType.contractInteraction on the redesign routes and creates the new component.
Related issues
Fixes: #23944
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist