Skip to content

feat: update header footer and title components#24168

Merged
pedronfigueiredo merged 4 commits intopnf/23944from
pnf/23950
Apr 24, 2024
Merged

feat: update header footer and title components#24168
pedronfigueiredo merged 4 commits intopnf/23944from
pnf/23950

Conversation

@pedronfigueiredo
Copy link
Copy Markdown
Contributor

@pedronfigueiredo pedronfigueiredo commented Apr 22, 2024 •
edited by github-actions bot
Loading

Description

Updates footer, header and title files to accept transaction confirmations

Open in GitHub Codespaces

Related issues

Fixes: #23950

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@pedronfigueiredo pedronfigueiredo self-assigned this Apr 22, 2024
@pedronfigueiredo pedronfigueiredo requested review from a team April 22, 2024 13:18
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 22, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@pedronfigueiredo pedronfigueiredo force-pushed the pnf/23944 branch 2 times, most recently from 2dfd037 to a8cfcda Compare April 22, 2024 13:28
jpuri
jpuri reviewed Apr 23, 2024
View reviewed changes
ui/pages/confirmations/components/confirm/utils.ts Outdated
Copy link
Copy Markdown
Contributor

@jpuri jpuri Apr 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be nice to unit test this function.

@jpuri
Copy link
Copy Markdown
Contributor

jpuri commented Apr 23, 2024

Changes look great, will be nicer to have more unit test coverage.

jpuri
jpuri approved these changes Apr 24, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@jpuri jpuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pedronfigueiredo pedronfigueiredo merged commit ca38cc1 into pnf/23944 Apr 24, 2024
@pedronfigueiredo pedronfigueiredo deleted the pnf/23950 branch April 24, 2024 10:16
@github-actions github-actions bot locked and limited conversation to collaborators Apr 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jpuri jpuri jpuri approved these changes

Assignees

@pedronfigueiredo pedronfigueiredo

Labels

confirmation-re-design confirmation-redesign team-confirmations-secure-ux-deprecated DEPRECATED: please use "team-confirmations" instead team-confirmations-secure-ux-PR PRs from the confirmations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pedronfigueiredo @jpuri