Description

The temporary solution is to:

• Prevent two network controller requests by:
• Patch the network controller so that the lookup on initializeProvidercan be avoided.
• Call that initializeProvider with the lookup: false argument right after the network controller is constructed
• Call await this.networkController.lookupNetwork(); at the end of the metamask controller if the onboarding has been completed
• Call await this.networkController.lookupNetwork(); once the onboarding complete state changes
• Prevent one accounts tracker request by:
• Moving the blockTracker event listener from the constructor of the controller to the start function

The long term solution will be
#23005 (currently blocked by #4004 on
core.

Related issues

Fixes: https://github.com/MetaMask/metamask-planning/issues/881

Manual testing steps

1. Add await new Promise((resolve) => setTimeout(resolve, 10000)); to the top of initialize on the background.js file
2. Build the app
3. Load extension and immediately open the network tab on the background console before the app initializes
4. No requests should happen

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've clearly explained what problem this PR is solving and how it is solved.
• I've linked related issues
• I've included manual testing steps
• I've included screenshots/recordings if applicable
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
• I’ve properly set the pull request status:
  • In case it's not yet "ready for review", I've set it to "draft".
• In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Description

Related issues

Fixes:

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.