fix: Prevent rpc request before onboarding is completed#23622
Merged
pedronfigueiredo merged 12 commits intodevelopfrom Mar 26, 2024
Merged
fix: Prevent rpc request before onboarding is completed#23622pedronfigueiredo merged 12 commits intodevelopfrom
pedronfigueiredo merged 12 commits intodevelopfrom
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
d16dad8 to
91acfcc
Compare
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
Contributor
Author
|
@SocketSecurity ignore npm/@metamask/safe-event-emitter@3.0.0 |
Collaborator
Builds ready [91acfcc]
Page Load Metrics (1381 ± 563 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
danjm
reviewed
Mar 21, 2024
danjm
reviewed
Mar 21, 2024
1b78a96 to
837e12d
Compare
Gudahtt
reviewed
Mar 22, 2024
Gudahtt
reviewed
Mar 22, 2024
Gudahtt
reviewed
Mar 22, 2024
Gudahtt
reviewed
Mar 22, 2024
.yarn/patches/@metamask-network-controller-npm-18.0.1-c4d0cfaecd.patch
Outdated
Show resolved
Hide resolved
Collaborator
Builds ready [7e532de]
Page Load Metrics (1019 ± 588 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
63af236 to
536ab0a
Compare
DDDDDanica
reviewed
Mar 25, 2024
brad-decker
previously approved these changes
Mar 25, 2024
430c5cd to
3988377
Compare
DDDDDanica
approved these changes
Mar 26, 2024
Collaborator
Builds ready [3988377]
Page Load Metrics (1232 ± 496 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
danjm
approved these changes
Mar 26, 2024
seaona
reviewed
Mar 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The temporary solution is to:
The long term solution will be #23005 (currently blocked by #4004 on core.
Related issues
Fixes: https://github.com/MetaMask/metamask-planning/issues/881
Manual testing steps
await new Promise((resolve) => setTimeout(resolve, 10000));to the top of initialize on the background.js fileScreenshots/Recordings
Before
Peek.2023-12-05.06-44.mp4
After
Peek.2023-12-05.06-31.mp4
Pre-merge author checklist
Pre-merge reviewer checklist