feat: Speed up wallet onboarding for developers#23615
Closed
pedronfigueiredo wants to merge 1 commit intodevelopfrom
Closed
feat: Speed up wallet onboarding for developers#23615pedronfigueiredo wants to merge 1 commit intodevelopfrom
pedronfigueiredo wants to merge 1 commit intodevelopfrom
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
|
you can allow developers to skip onboarding entirely using an approach like was done here #19389 |
7 tasks
Contributor
|
This PR has been automatically marked as stale because it has not had recent activity in the last 60 days. It will be closed in 14 days. Thank you for your contributions. |
pedronfigueiredo
added a commit
that referenced
this pull request
May 27, 2024
## **Description** - Implements a new development build script that skips onboarding by preloading state from the end-to-end test fixtures. - The vault state is dynamically generated from the environment variables `TEST_SRP` and `PASSWORD`. - This build hides all the "What's New?" modals and the "Product Tour" as well as all onboarding screens. - The network is set to "Sepolia" by default. - Alternatively, onboarding can be skipped without setting a `TEST_SRP`, in which case the e2e tests SRP and accounts are used. [](https://codespaces.new/MetaMask/metamask-extension/pull/23781?quickstart=1) ## **Related issues** Related: #23615, #19389 ## **Manual testing steps** 1. Checkout this branch 2. Set a `TEST_SRP` environment variable on your `.metamaskrc` file as well as `PASSWORD` if you haven't already 3. Run `yarn start:skip-onboarding` 4. Load the extension on your favorite browser and open the popup ## **Screenshots/Recordings** ### **After** https://github.com/MetaMask/metamask-extension/assets/13814744/e34bac0f-8f6f-4d04-8452-b9962c99cfb9 ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Contributor
Author
|
closing this one now that #23781 has been merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
TEST_SRP, which can be defined in the.metamaskrcfile. When set, this variable prepopulates the import SRP input field during the onboarding process with a preferred testing wallet.TEST_SRPvariable signals developers’ intent to expedite the onboarding process, this automatically checks all onboarding checkboxes and enables all progression buttons.PASSWORDenvironment variable for automatic wallet unlocking, the onboarding process now includes this password prepopulated.Related issues
Fixes: N/A
Manual testing steps
TEST_SRPandPASSWORDto your.metamaskrcfileScreenshots/Recordings
Screen.Recording.2024-03-20.at.19.28.07.mov
Pre-merge author checklist
Pre-merge reviewer checklist