Skip to content

chore: add words to Code Spell Checker#23405

Merged
HowardBraham merged 5 commits intodevelopfrom
add-words-to-cspell
Mar 26, 2024
Merged

chore: add words to Code Spell Checker#23405
HowardBraham merged 5 commits intodevelopfrom
add-words-to-cspell

Conversation

@HowardBraham
Copy link
Copy Markdown
Contributor

@HowardBraham HowardBraham commented Mar 8, 2024

Description

Add a bunch of words to the Code Spell Checker dictionary, and also fix a few typos.

Open in GitHub Codespaces

Related issues

Followup to: #23210

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

@HowardBraham HowardBraham added the team-extension-platform Extension Platform team label Mar 8, 2024
@HowardBraham HowardBraham self-assigned this Mar 8, 2024
@HowardBraham HowardBraham requested review from a team, brad-decker and kumavis as code owners March 8, 2024 22:17
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 8, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.82%. Comparing base (737fdb1) to head (6c6fa0a).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #23405   +/-   ##
========================================
  Coverage    68.82%   68.82%           
========================================
  Files         1170     1170           
  Lines        44391    44391           
  Branches     11879    11879           
========================================
  Hits         30549    30549           
  Misses       13842    13842           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [52f8918]
Page Load Metrics (1515 ± 170 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint712171303818
domContentLoaded1283392211
load7518281515353170
domInteractive1283392211
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@HowardBraham HowardBraham force-pushed the add-words-to-cspell branch 4 times, most recently from 50f517e to d642065 Compare March 13, 2024 21:29
davidmurdoch
davidmurdoch previously approved these changes Mar 13, 2024
@hjetpoluru hjetpoluru self-requested a review March 17, 2024 16:59
Copy link
Copy Markdown
Contributor

@hjetpoluru hjetpoluru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you include the below words:-

ignoreWords
eamodio
azuretools
rvest
Brainstem
autofetch

Words
Predicition
devcontainers
Codespace
tsconfigs
tsbuildinfo
typecheck
MULTICHAIN
MULTIPROVIDER

davidmurdoch
davidmurdoch previously approved these changes Mar 18, 2024
@hjetpoluru hjetpoluru self-requested a review March 18, 2024 14:59
hjetpoluru
hjetpoluru previously approved these changes Mar 18, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [5c32237]
Page Load Metrics (1591 ± 538 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint862361273617
domContentLoaded148430209
load66279815911120538
domInteractive148430209
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [0748392]
Page Load Metrics (502 ± 393 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint624001358139
domContentLoaded990352211
load502309502818393
domInteractive990352211
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [07f81e9]
Page Load Metrics (789 ± 459 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint741971194120
domContentLoaded105125126
load602321789956459
domInteractive105125126
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [6c6fa0a]
Page Load Metrics (667 ± 419 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint652501234522
domContentLoaded98332209
load532172667873419
domInteractive98332199
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

*
* @param decimals - the amount of decimal precision to use when rounding
* @returns A fixed point decimal string represenation of the Numeric
* @returns A fixed point decimal string representation of the Numeric
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch. lol. Might as well call this PR "Fix Brad's typos"

@HowardBraham HowardBraham merged commit 4a5870a into develop Mar 26, 2024
@HowardBraham HowardBraham deleted the add-words-to-cspell branch March 26, 2024 23:47
@github-actions github-actions bot locked and limited conversation to collaborators Mar 26, 2024
@metamaskbot metamaskbot added the release-11.15.0 Issue or pull request that will be included in release 11.15.0 label Mar 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-11.15.0 Issue or pull request that will be included in release 11.15.0 team-extension-platform Extension Platform team

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants