chore: add spellchecker extension recommendation for VSCode developers; add lavamoat & blockaid to workspace dictionary#23210
Merged
davidmurdoch merged 1 commit intodevelopfrom Mar 1, 2024
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #23210 +/- ##
========================================
Coverage 68.61% 68.61%
========================================
Files 1098 1098
Lines 43103 43103
Branches 11513 11513
========================================
Hits 29571 29571
Misses 13532 13532 ☔ View full report in Codecov by Sentry. |
Collaborator
Builds ready [f3b10df]
Page Load Metrics (1246 ± 414 ms)
Bundle size diffs
|
…s; add lavamoat & blockaid to workspace dictionary
Collaborator
Builds ready [b637097]
Page Load Metrics (1099 ± 363 ms)
Bundle size diffs
|
DDDDDanica
approved these changes
Mar 1, 2024
brad-decker
approved these changes
Mar 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new extension recommendation for developers using VSCode:
Code Spell Checker. It is optional to install, but when installed is useful for catching misspellings in code, comments, prose, etc.Two downsides to using the extension:
See the
Code Spell CheckerVSCode extension documentation for details: https://marketplace.visualstudio.com/items?itemName=streetsidesoftware.code-spell-checkerTo Test:
Ctrl/Cmd+ Shift + X, then search for "Code Spell Checker" (by "Street Side Software")Ctrl/Cmd + .or click the lightbulb icon that appears.Examples:
Misspellings will show a squiggly underline:
Demonstrating Suggestions and Add to Dictionary:
Tooltip of a misspelling:
VSCode "Problems" panel:
Misspellings are highlighted in blue (dark mode) in the VSCode scroll bar:
This PR only adds two words to the dictionary: lavamoat and blockaid, just to get things started. I expect many more domain-specific words and abbreviations will be added over time.
If you hate this idea, let me know!