fix: allow onboarding and unlocking wallet without Infura mainnet connectivity#23388
Merged
legobeat merged 3 commits intoMetaMask:developfrom Mar 13, 2024
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
c3aa7dd to
cdaee62
Compare
pedronfigueiredo
approved these changes
Mar 8, 2024
8a328c8 to
f4e1fe9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #23388 +/- ##
===========================================
- Coverage 68.72% 68.72% -0.00%
===========================================
Files 1124 1124
Lines 43606 43605 -1
Branches 11669 11668 -1
===========================================
- Hits 29967 29965 -2
- Misses 13639 13640 +1 ☔ View full report in Codecov by Sentry. |
f4e1fe9 to
9b06bc6
Compare
DDDDDanica
approved these changes
Mar 12, 2024
9b06bc6 to
4ebb6fd
Compare
Collaborator
|
No release label on PR. Adding release label release-11.14.0 on PR, as PR was added to branch 11.14.0 when release was cut. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue where custom networks are not configurable until after wallet is unlocked.
Related issues
Manual testing steps
Screenshots/Recordings
Before
no-add-network-p.mp4
After
can-add-network-p.mp4
Pre-merge author checklist
Pre-merge reviewer checklist