Skip to content

Fix #20274 - Update locked network menu controls#20277

Merged
darkwing merged 5 commits intodevelopfrom
20274-locked-network-controls
Aug 3, 2023
Merged

Fix #20274 - Update locked network menu controls#20277
darkwing merged 5 commits intodevelopfrom
20274-locked-network-controls

Conversation

@darkwing
Copy link
Copy Markdown
Contributor

@darkwing darkwing commented Jul 28, 2023

Explanation

This PR ensures (1) the user doesn't see the "delete network" icon when MetaMask is locked, and (2) the user doesn't see the "Add Networks" button when locked.

Manual Testing Steps

  1. Lock MetaMask
  2. See the "Add network" button disabled
  3. See no delete icon when hovering over custom network

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@darkwing darkwing requested a review from a team as a code owner July 28, 2023 21:51
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 28, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@darkwing darkwing force-pushed the 20274-locked-network-controls branch from 51c1f24 to 8315930 Compare July 29, 2023 20:01
NidhiKJha
NidhiKJha approved these changes Jul 31, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@NidhiKJha NidhiKJha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Aug 1, 2023

Builds ready [78ed87a]
Page Load Metrics (1664 ± 64 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint110170141199
domContentLoaded14441935166313264
load14441950166413464
domInteractive14441935166313264
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 67 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Aug 2, 2023

Builds ready [553f089]
Page Load Metrics (1653 ± 73 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1121851472412
domContentLoaded13842017165315373
load13842017165315373
domInteractive13842017165315373
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 67 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 2, 2023 •
edited
Loading

Codecov Report

Merging #20277 (553f089) into develop (f91d4fb) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop   #20277   +/-   ##
========================================
  Coverage    68.79%   68.80%           
========================================
  Files          990      990           
  Lines        38089    38091    +2     
  Branches     10205    10206    +1     
========================================
+ Hits         26203    26205    +2     
  Misses       11886    11886
Files Changed Coverage Δ
.../multichain/network-list-menu/network-list-menu.js 71.43% <100.00%> (+0.76%) ⬆️

@darkwing darkwing merged commit 72cc669 into develop Aug 3, 2023
@darkwing darkwing deleted the 20274-locked-network-controls branch August 3, 2023 14:20
@github-actions github-actions bot locked and limited conversation to collaborators Aug 3, 2023
@metamaskbot metamaskbot added the release-10.36.0 Issue or pull request that will be included in release 10.36.0 label Aug 3, 2023
@Gudahtt Gudahtt added release-11.1.0 Issue or pull request that will be included in release 11.1.0 and removed release-10.36.0 Issue or pull request that will be included in release 10.36.0 labels Sep 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@pedronfigueiredo pedronfigueiredo pedronfigueiredo approved these changes

@NidhiKJha NidhiKJha NidhiKJha approved these changes

Assignees

No one assigned

Labels

release-11.1.0 Issue or pull request that will be included in release 11.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove the ability to delete networks while locked

5 participants

@darkwing @metamaskbot @pedronfigueiredo @NidhiKJha @Gudahtt