feat: add option to hide submit button in the confirmation template by vinistevam · Pull Request #23085 · MetaMask/metamask-extension

vinistevam · 2024-02-21T11:46:05Z

Description

This PR aims to add an option to hide the submit button in the confirmation template.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2129

Manual testing steps

Note: It won't be possible to test this option as it was not adopted by any confirmation template.
I recorded a video to show the behaviour with the new option while I was testing.

Test regression adding chain and snaps both are using confirmation template.
Chain:

Go to https://chainlist.org/ page
Add a chain to MetaMask
Successfully added

Snap:

Go to https://snaps.metamask.io/explore/ page
Install a snap to MetaMask
Successfully installed

Screenshots/Recordings

hide-submit-btn.webm

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-02-21T11:46:16Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

codecov · 2024-02-21T11:48:07Z

Codecov Report

Attention: Patch coverage is 90.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 68.59%. Comparing base (62af0c6) to head (3a6cd48).

Files	Patch %	Lines
...ponents/confirmation-footer/confirmation-footer.js	88.89%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #23085   +/-   ##
========================================
  Coverage    68.58%   68.59%           
========================================
  Files         1098     1098           
  Lines        43332    43336    +4     
  Branches     11551    11555    +4     
========================================
+ Hits         29719    29723    +4     
  Misses       13613    13613

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

metamaskbot · 2024-02-21T11:52:44Z

Builds ready [607933a]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6, 7
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1882 ± 121 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	114	435	176	75	36
		domContentLoaded	9	52	22	12	6
		load	1437	2505	1882	253	121
		domInteractive	9	52	22	12	6

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 170 Bytes (0.00%)
common: 0 Bytes (0.00%)

…emplate

metamaskbot · 2024-02-21T12:21:33Z

Builds ready [53ea49d]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6, 7
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1987 ± 99 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	116	467	195	100	48
		domContentLoaded	10	83	32	19	9
		load	1622	2407	1987	206	99
		domInteractive	10	83	32	19	9

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 170 Bytes (0.00%)
common: 0 Bytes (0.00%)

dbrans · 2024-02-27T15:23:45Z

Here's what it looks like if you do not render the actions in the confirmation footer (contrived example).

Specifically the alerts are still visible.

…bmit-btn-confirmation-template

dbrans · 2024-02-27T17:02:33Z

Linting will be fixed by #23204

…bmit-btn-confirmation-template

metamaskbot · 2024-02-27T18:20:38Z

Builds ready [3a6cd48]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1181 ± 391 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	77	178	124	33	16
		domContentLoaded	9	62	30	16	8
		load	64	2080	1181	815	391
		domInteractive	9	62	30	16	8

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 68 Bytes (0.00%)
common: 0 Bytes (0.00%)

dbrans · 2024-02-28T17:10:33Z

Manual verification

Adding BNB Chain on chainlist.org

Before

After

Manually setting hideSubmitButton = true in template add-ethereum-chain.js

feat: add option to hide submit button confirmation template

607933a

vinistevam added the team-confirmations-system-deprecated DEPRECATED: please use "team-confirmations" instead label Feb 21, 2024

Merge branch 'develop' into add-option-hide-submit-btn-confirmation-t…

53ea49d

…emplate

vinistevam marked this pull request as ready for review February 21, 2024 13:23

vinistevam requested a review from a team as a code owner February 21, 2024 13:23

matthewwalsh0 reviewed Feb 22, 2024

View reviewed changes

Comment thread ui/pages/confirmations/confirmation/confirmation.js Outdated

Comment thread ui/pages/confirmations/confirmation/confirmation.js Outdated

Addressing PR comments

b16624d

Reverting button change

b6d8afd

dbrans force-pushed the add-option-hide-submit-btn-confirmation-template branch from 5e46087 to b6d8afd Compare February 27, 2024 15:52

Fix a negation.

f82b3f7

vinistevam requested review from a team, HowardBraham, brad-decker, kumavis and plasmacorral as code owners February 27, 2024 16:15

Merge remote-tracking branch 'origin/develop' into add-option-hide-su…

d0975e2

…bmit-btn-confirmation-template

dbrans force-pushed the add-option-hide-submit-btn-confirmation-template branch from dbc7964 to d0975e2 Compare February 27, 2024 16:18

HowardBraham removed request for a team, HowardBraham, brad-decker and plasmacorral February 27, 2024 16:39

HowardBraham removed the request for review from kumavis February 27, 2024 16:40

Merge remote-tracking branch 'origin/develop' into add-option-hide-su…

3a6cd48

…bmit-btn-confirmation-template

matthewwalsh0 approved these changes Feb 28, 2024

View reviewed changes

OGPoyraz approved these changes Feb 28, 2024

View reviewed changes

dbrans merged commit 5fdb69c into develop Feb 28, 2024

dbrans deleted the add-option-hide-submit-btn-confirmation-template branch February 28, 2024 17:11

github-actions Bot locked and limited conversation to collaborators Feb 28, 2024

metamaskbot added the release-11.13.0 Issue or pull request that will be included in release 11.13.0 label Feb 28, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add option to hide submit button in the confirmation template#23085

feat: add option to hide submit button in the confirmation template#23085
dbrans merged 7 commits into
developfrom
add-option-hide-submit-btn-confirmation-template

vinistevam commented Feb 21, 2024 •

edited

Loading

Uh oh!

github-actions Bot commented Feb 21, 2024

Uh oh!

codecov Bot commented Feb 21, 2024 •

edited

Loading

Uh oh!

metamaskbot commented Feb 21, 2024

Uh oh!

metamaskbot commented Feb 21, 2024

Uh oh!

Uh oh!

Uh oh!

dbrans commented Feb 27, 2024

Uh oh!

dbrans commented Feb 27, 2024

Uh oh!

metamaskbot commented Feb 27, 2024

Uh oh!

dbrans commented Feb 28, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

vinistevam commented Feb 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions Bot commented Feb 21, 2024

Uh oh!

codecov Bot commented Feb 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

metamaskbot commented Feb 21, 2024

Uh oh!

metamaskbot commented Feb 21, 2024

Uh oh!

Uh oh!

Uh oh!

dbrans commented Feb 27, 2024

Uh oh!

dbrans commented Feb 27, 2024

Uh oh!

metamaskbot commented Feb 27, 2024

Uh oh!

dbrans commented Feb 28, 2024

Manual verification

Before

After

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

vinistevam commented Feb 21, 2024 •

edited

Loading

codecov Bot commented Feb 21, 2024 •

edited

Loading