Skip to content

fix: lint fix for no connections#23204

Merged
HowardBraham merged 2 commits into
developfrom
lint-fix-no-connection
Feb 27, 2024
Merged

fix: lint fix for no connections#23204
HowardBraham merged 2 commits into
developfrom
lint-fix-no-connection

Conversation

@NidhiKJha

@NidhiKJha NidhiKJha commented Feb 27, 2024

Copy link
Copy Markdown
Member

This PR is to fix the lint error in NoConnections test

Related issues

Fixes:

Manual testing steps

  1. Everything should work

Screenshots/Recordings

Before

NA

After

NA

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@NidhiKJha NidhiKJha added the team-core-extension-ux Core Extension UX team label Feb 27, 2024
@NidhiKJha NidhiKJha requested a review from a team as a code owner February 27, 2024 16:25
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Feb 27, 2024
@dbrans dbrans mentioned this pull request Feb 27, 2024
Merged
13 tasks
@codecov

codecov Bot commented Feb 27, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.58%. Comparing base (14181de) to head (b00e2e4).

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #23204   +/-   ##
========================================
  Coverage    68.58%   68.58%           
========================================
  Files         1098     1098           
  Lines        43332    43332           
  Branches     11551    11551           
========================================
  Hits         29719    29719           
  Misses       13613    13613

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HowardBraham HowardBraham merged commit 62af0c6 into develop Feb 27, 2024
@HowardBraham HowardBraham deleted the lint-fix-no-connection branch February 27, 2024 17:16
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 27, 2024
@metamaskbot metamaskbot added the release-11.13.0 Issue or pull request that will be included in release 11.13.0 label Feb 27, 2024
@metamaskbot

metamaskbot commented Feb 27, 2024

Copy link
Copy Markdown
Collaborator
Builds ready [b00e2e4]
Page Load Metrics (1216 ± 361 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint651871202512
domContentLoaded993332311
load5319271216752361
domInteractive993332311
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DDDDDanica DDDDDanica DDDDDanica approved these changes

+2 more reviewers

@dbrans dbrans dbrans approved these changes

@vthomas13 vthomas13 vthomas13 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template release-11.13.0 Issue or pull request that will be included in release 11.13.0 team-core-extension-ux Core Extension UX team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@NidhiKJha @metamaskbot @dbrans @vthomas13 @DDDDDanica @HowardBraham