Skip to content

Add deprecated comment on displayWarning#22853

Merged
OGPoyraz merged 7 commits intodevelopfrom
deprecate-displaywarning-function
Feb 13, 2024
Merged

Add deprecated comment on displayWarning#22853
OGPoyraz merged 7 commits intodevelopfrom
deprecate-displaywarning-function

Conversation

@OGPoyraz
Copy link
Copy Markdown
Member

@OGPoyraz OGPoyraz commented Feb 7, 2024

Description

This PR aims to mark displayWarning as deprecated.

Related issues

N/A

Manual testing steps

No functional change

Screenshots/Recordings

N/A

Before

N/A

After

N/A

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@OGPoyraz OGPoyraz requested a review from a team as a code owner February 7, 2024 13:29
@Gudahtt Gudahtt added the team-extension-platform Extension Platform team label Feb 7, 2024
Gudahtt
Gudahtt previously approved these changes Feb 7, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt
Copy link
Copy Markdown
Member

Gudahtt commented Feb 7, 2024

Comment originally added here: #17465, but it was accidentally removed later.

Gudahtt
Gudahtt reviewed Feb 7, 2024
View reviewed changes
@OGPoyraz @Gudahtt
Update ui/store/actions.ts
45cad8b 
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Gudahtt
Gudahtt reviewed Feb 7, 2024
View reviewed changes
@OGPoyraz @Gudahtt
Update ui/store/actions.ts
1518ca3 
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3e00753) 68.44% compared to head (1518ca3) 68.44%.
Report is 6 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #22853   +/-   ##
========================================
  Coverage    68.44%   68.44%           
========================================
  Files         1089     1089           
  Lines        42899    42899           
  Branches     11427    11427           
========================================
  Hits         29362    29362           
  Misses       13537    13537

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Feb 8, 2024

Builds ready [1518ca3]
Page Load Metrics (818 ± 26 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint94148110157
domContentLoaded9482084
load7449358185426
domInteractive9482084
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

dbrans
dbrans approved these changes Feb 8, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@dbrans dbrans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Gudahtt
Gudahtt approved these changes Feb 8, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@OGPoyraz OGPoyraz merged commit 727ccfe into develop Feb 13, 2024
@OGPoyraz OGPoyraz deleted the deprecate-displaywarning-function branch February 13, 2024 09:34
@github-actions github-actions bot locked and limited conversation to collaborators Feb 13, 2024
@metamaskbot metamaskbot added the release-11.12.0 Issue or pull request that will be included in release 11.12.0 label Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

@matthewwalsh0 matthewwalsh0 matthewwalsh0 approved these changes

+1 more reviewer

@dbrans dbrans dbrans approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-11.12.0 Issue or pull request that will be included in release 11.12.0 team-extension-platform Extension Platform team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@OGPoyraz @Gudahtt @metamaskbot @dbrans @matthewwalsh0