Document displayWarning as deprecated#17465
Merged
Conversation
The `displayWarning` action creator will show the error in various different places in the UI. This is confusing for users, we should stop doing this. Instead we can consider each error case separately. If there is a scenario where it's appropriate to tell a user about an error, we should build that case into the relevant UI and use localized error messages.
7 tasks
Collaborator
Builds ready [6303dcd]
Page Load Metrics (1493 ± 117 ms)
Bundle size diffs
|
danjm
approved these changes
Jan 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
displayWarningaction creator will show the error in various different places in the UI. This is confusing for users, we should stop doing this.Instead we can consider each error case separately. If there is a scenario where it's appropriate to tell a user about an error, we should build that case into the relevant UI and use localized error messages.
Manual Testing Steps
No functional changes, just inline docs.
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Boardlabel.In this case, a QA Engineer approval will be be required.