Skip to content

feat: BlockaidBannerAlert update Failed type false positive support#22742

Merged
digiwand merged 3 commits intodevelopfrom
feat-blockaid-report-false-positive-failed-type
Feb 6, 2024
Merged

feat: BlockaidBannerAlert update Failed type false positive support#22742
digiwand merged 3 commits intodevelopfrom
feat-blockaid-report-false-positive-failed-type

Conversation

@digiwand
Copy link
Copy Markdown
Contributor

@digiwand digiwand commented Jan 31, 2024

Description

See issue for details

note: we will need to resolve merge conflicts with #22625

Related issues

Fixes: #22711

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@digiwand digiwand added the team-confirmations-secure-ux-PR PRs from the confirmations team label Jan 31, 2024
@digiwand digiwand requested a review from a team as a code owner January 31, 2024 03:30
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 31, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 31, 2024 •
edited
Loading

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (42922cc) 68.45% compared to head (1e0d243) 68.47%.
Report is 2 commits behind head on develop.

Files Patch % Lines
ui/pages/confirm-signature-request/index.js 91.67% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #22742      +/-   ##
===========================================
+ Coverage    68.45%   68.47%   +0.01%     
===========================================
  Files         1088     1088              
  Lines        42813    42829      +16     
  Branches     11396    11396              
===========================================
+ Hits         29307    29323      +16     
  Misses       13506    13506

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jan 31, 2024

Builds ready [2e250be]
Page Load Metrics (795 ± 25 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint87150118178
domContentLoaded9441974
load7119137955225
domInteractive9441974
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 20 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

segun
segun reviewed Jan 31, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@segun segun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, only address the comment by @jpuri

@digiwand digiwand mentioned this pull request Feb 2, 2024
Merged
13 tasks
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Feb 2, 2024

Builds ready [6127a82]
Page Load Metrics (826 ± 32 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint96159120189
domContentLoaded114820105
load7319708266632
domInteractive104720105
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 41 Bytes (0.00%)
  • common: 18 Bytes (0.00%)

@digiwand digiwand requested review from a team, brad-decker and kumavis as code owners February 5, 2024 16:09
@digiwand digiwand force-pushed the feat-blockaid-report-false-positive-failed-type branch from c4157c9 to 1e0d243 Compare February 5, 2024 16:13
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Feb 5, 2024

Builds ready [1e0d243]
Page Load Metrics (1153 ± 224 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint844051808943
domContentLoaded9121363014
load65825001153467224
domInteractive9121363014
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 75 Bytes (0.00%)
  • common: 18 Bytes (0.00%)

@digiwand digiwand merged commit c8797f4 into develop Feb 6, 2024
@digiwand digiwand deleted the feat-blockaid-report-false-positive-failed-type branch February 6, 2024 17:31
@github-actions github-actions bot locked and limited conversation to collaborators Feb 6, 2024
@metamaskbot metamaskbot added the release-11.11.0 Issue or pull request that will be included in release 11.11.0 label Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jpuri jpuri jpuri approved these changes

@kumavis kumavis Awaiting requested review from kumavis

@brad-decker brad-decker Awaiting requested review from brad-decker

+1 more reviewer

@segun segun segun approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-11.11.0 Issue or pull request that will be included in release 11.11.0 team-confirmations-secure-ux-PR PRs from the confirmations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feat]: Support Blockaid Reporting False Positives Failed result type

4 participants

@digiwand @metamaskbot @segun @jpuri