Refactor and update blockaid banner alert by digiwand · Pull Request #22625 · MetaMask/metamask-extension

digiwand · 2024-01-22T18:58:26Z

Description

minor cleanup before more updates on BlockaidBannerAlert and SecurityProviderBannerAlert

update domain prop to include txData?.origin
display "Provided by" even on failed tx
update storybook controls to redisplay dropdown and without "NotApplicable" types
alphabetize params
rm redundant getDisclosureTitle function

Related issues

Fixes: #22624

Manual testing steps

run storybook yarn storybook
go to http://localhost:6006/?path=/docs/components-app-securityproviderbanneralert-blockaidbanneralert--docs

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

- adds specificity

This reverts commit c475253.

This reverts commit 1931e64.

github-actions · 2024-01-22T18:58:38Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

ui/components/app/security-provider-banner-alert/blockaid-banner-alert/blockaid-banner-alert.js

…ailed"

…as "Failed"

metamaskbot · 2024-01-22T20:26:24Z

Builds ready [b6df572]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6, 7
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1469 ± 173 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	86	517	184	88	42
		domContentLoaded	9	180	49	52	25
		load	866	2062	1469	360	173
		domInteractive	9	180	48	52	25

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 114 Bytes (0.00%)
common: 36 Bytes (0.00%)

codecov · 2024-01-22T20:32:58Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9a92987) 68.33% compared to head (d06c1a6) 68.33%.
Report is 1 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #22625      +/-   ##
===========================================
- Coverage    68.33%   68.33%   -0.00%     
===========================================
  Files         1088     1088              
  Lines        42803    42798       -5     
  Branches     11390    11388       -2     
===========================================
- Hits         29247    29242       -5     
  Misses       13556    13556

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…me as "Failed"" This reverts commit ae2f343 & 48b7288

digiwand · 2024-01-24T03:24:05Z

ui/components/app/security-provider-banner-alert/blockaid-banner-alert/blockaid-banner-alert.js

+      jsonRpcParams: JSON.stringify(txParams ?? msgParams),
+      resultType,
+      reproduce: JSON.stringify(features),
+    };


the only key/value prop updated here is domain. all others were reordered alphabetically

metamaskbot · 2024-01-24T03:53:16Z

Builds ready [046c27c]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6, 7
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (800 ± 19 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	102	139	116	12	6
		domContentLoaded	11	24	17	3	2
		load	745	866	800	39	19
		domInteractive	11	24	17	3	1

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 19 Bytes (0.00%)
common: 36 Bytes (0.00%)

metamaskbot · 2024-02-01T16:08:06Z

Builds ready [d06c1a6]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6, 7
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (810 ± 28 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	93	136	113	12	6
		domContentLoaded	9	23	15	4	2
		load	717	911	810	59	28
		domInteractive	9	23	15	4	2

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 19 Bytes (0.00%)
common: 36 Bytes (0.00%)

digiwand added 12 commits January 22, 2024 09:14

feat: readd storybook controls to support changing values

f88450c

refactor: Blockaid encapsulate reportUrl logic

d5c374f

feat: Blockaid readd provider footer msg for failed

b180f02

refactor: BlockaidBannerAlert alphabetize reportData

c0e3958

fix: SecurityProviderBannerAlert optional onClickSupportLink

1931e64

refactor: SecurityProviderBannerAlert seeDetails redundancy

c475253

feat: SecurityProviderBannerAlert optional Disclosure

f5d0994

refactor: UTM_SOURCE -> SECURITY_PROVIDER_UTM_SOURCE

e3637a5

- adds specificity

refactor: alphabetize

d63c622

Revert "refactor: SecurityProviderBannerAlert seeDetails redundancy"

bf03ade

This reverts commit c475253.

Revert "fix: SecurityProviderBannerAlert optional onClickSupportLink"

ffc85a6

This reverts commit 1931e64.

refactor: SecurityProviderBannerAlert rm getDisclosureTitle

13216b1

digiwand requested a review from a team as a code owner January 22, 2024 18:58

digiwand commented Jan 22, 2024

View reviewed changes

ui/components/app/security-provider-banner-alert/blockaid-banner-alert/blockaid-banner-alert.js Outdated Show resolved Hide resolved

digiwand added 3 commits January 22, 2024 11:02

feat: BlockaidBannerAlert handle "NotApplicable" types the same as "F…

ae2f343

…ailed"

test:feat: BlockaidBannerAlert handle "NotApplicable" types the same …

48b7288

…as "Failed"

test:fix: BlockaidBannerAlert update

b6df572

digiwand added the team-confirmations-secure-ux-deprecated DEPRECATED: please use "team-confirmations" instead label Jan 22, 2024

jpuri previously approved these changes Jan 23, 2024

View reviewed changes

digiwand added 3 commits January 23, 2024 19:09

Revert "feat: BlockaidBannerAlert handle "NotApplicable" types the sa…

b3e324f

…me as "Failed"" This reverts commit ae2f343 & 48b7288

feat:storybook: BlockaidBannerAlert filter out "Not Applicable" types

5eadf8d

refactor:storybook: fix BlockaidBannerAlert txData control

650aca9

digiwand dismissed jpuri’s stale review via 650aca9 January 24, 2024 03:19

digiwand requested a review from jpuri January 24, 2024 03:19

digiwand added 2 commits January 23, 2024 19:19

Merge branch 'develop' into refactor-and-update-blockaid-banner-alert

256b215

fix: update BlockaidBannerAlert reportUrl domain w/ txParams.origin

046c27c

digiwand commented Jan 24, 2024

View reviewed changes

jpuri previously approved these changes Jan 25, 2024

View reviewed changes

digiwand requested review from blackdevelopa and segun January 29, 2024 16:02

digiwand mentioned this pull request Jan 31, 2024

feat: BlockaidBannerAlert update Failed type false positive support #22742

Merged

13 tasks

segun previously approved these changes Jan 31, 2024

View reviewed changes

Merge branch 'develop' into refactor-and-update-blockaid-banner-alert

d06c1a6

digiwand dismissed stale reviews from segun and jpuri via d06c1a6 February 1, 2024 15:33

digiwand requested review from jpuri and segun February 1, 2024 15:55

segun approved these changes Feb 1, 2024

View reviewed changes

jpuri approved these changes Feb 5, 2024

View reviewed changes

digiwand merged commit 5a968da into develop Feb 5, 2024

digiwand deleted the refactor-and-update-blockaid-banner-alert branch February 5, 2024 15:00

github-actions bot locked and limited conversation to collaborators Feb 5, 2024

metamaskbot added the release-11.11.0 Issue or pull request that will be included in release 11.11.0 label Feb 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor and update blockaid banner alert#22625

Refactor and update blockaid banner alert#22625
digiwand merged 21 commits intodevelopfrom
refactor-and-update-blockaid-banner-alert

digiwand commented Jan 22, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Jan 22, 2024

Uh oh!

Uh oh!

metamaskbot commented Jan 22, 2024

Uh oh!

codecov bot commented Jan 22, 2024 •

edited

Loading

Uh oh!

digiwand Jan 24, 2024

Uh oh!

metamaskbot commented Jan 24, 2024

Uh oh!

metamaskbot commented Feb 1, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

digiwand commented Jan 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Jan 22, 2024

Uh oh!

Uh oh!

metamaskbot commented Jan 22, 2024

Uh oh!

codecov bot commented Jan 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

digiwand Jan 24, 2024

Choose a reason for hiding this comment

Uh oh!

metamaskbot commented Jan 24, 2024

Uh oh!

metamaskbot commented Feb 1, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

digiwand commented Jan 22, 2024 •

edited

Loading

codecov bot commented Jan 22, 2024 •

edited

Loading