Version v11.7.2 by danjm · Pull Request #22336 · MetaMask/metamask-extension

danjm · 2023-12-19T09:10:11Z

No description provided.

github-actions · 2023-12-19T09:10:22Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

socket-security · 2023-12-19T10:38:29Z

No top level dependency changes detected. Learn more about Socket for GitHub ↗︎

socket-security · 2023-12-19T10:38:34Z

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Gudahtt · 2023-12-19T14:28:42Z

CHANGELOG.md

This changelog needs to be fixed; we have two empty sections and we're missing a change entry

Hey @Gudahtt i believe this list is still WIP but i have included the latest changes here #1a6d367a please take a look at it and let me know if there's any issues.

Gudahtt · 2023-12-19T14:48:53Z

privacy-snapshot.json

We should be able to remove api.coingecko.com from this list now as well

Fixed here #22372

Gudahtt · 2023-12-19T14:57:02Z

app/scripts/metamask-controller.js

We should be subscribed to networkDidChange here

@Gudahtt The code changes you commented on are now part of v11.7.3 #22354

I wanted to clarify on the point you made here though. Are you saying these lines of code should be changed to:

onNetworkDidChange: networkControllerMessenger.subscribe.bind( networkControllerMessenger, 'NetworkController:networkDidChange', )

Fixed here #22372

Gudahtt · 2023-12-19T14:59:52Z

app/scripts/metamask-controller.js

A few lines below here, the getERC20TokenName option should be removed. This option is not accepted as of v21

BREAKING: TokensController.watchAsset now performs on-chain validation of the asset's symbol and decimals, if they're defined in the contract (MetaMask/core#1745)

The TokensController constructor no longer accepts a getERC20TokenName option. It was no longer needed due to this change.

Fixed here #22372

Gudahtt · 2023-12-19T15:03:30Z

I found a few minor issues with the code changes here, but we should fix them on develop first before fixing them here. Any changes introduced in this PR will be undone with the sync back to develop.

Fix the `dropped` status detection. Ensure previously pending transactions are monitored after switching network and not stuck as `pending`. Prevent `failed` transactions on networks that use pending transaction receipts with `null` status. Fix recording of `v` value. Fix usage of saved gas fees.

danjm · 2023-12-20T09:02:45Z

The commits in this PR have changed from when it was first cut. What was v11.7.2 yesterday is now v11.7.3 #22354 So the above comments on needed code changes now apply to v11.7.3

This new v11.7.2 contains a single commit focused on fixing transaction status display bugs

metamaskbot · 2023-12-20T09:06:01Z

Builds ready [622a783]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6, 7
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (590 ± 284 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	95	171	123	22	11
		domContentLoaded	77	167	110	23	11
		load	90	1402	590	592	284
		domInteractive	77	167	110	23	11

metamaskbot · 2023-12-20T18:27:03Z

Builds ready [622a783]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6, 7
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (697 ± 313 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	92	195	126	28	13
		domContentLoaded	76	177	116	27	13
		load	88	1814	697	651	313
		domInteractive	76	176	116	27	13

sleepytanya · 2023-12-20T18:41:30Z

Confirmed for all test networks on Chrome and Firefox:

incoming transactions history on Linea Goerli is fixed [Bug]: Incoming transactions are not visible in the Activity list on Firefox RC 11.8.0 (Linea Goerli) #22237
saved gas fee (Advanced gas) applied to all subsequent transactions unless user changes gas settings to another option [Bug]: Gas fix or default value not working in recent updates. #22333
I don't see 'dropped' transaction issue (scenario 1 - create tx, switch network, create tx with the same account and with the same nonce, scenario 2 - send eth between two accounts on the same wallet and same network with the same nonce / higher / lower nonce) [Bug]: Swap shows as Dropped in MM UI and successful on chain (example - LINEA) #22312
I sent around 50 txs while testing but encountered 'pending' transaction only once and the status was updated pretty quick so we can count it as accidental one-time issue (?) and consider 'pending' transaction issue fixed [Bug]: Transaction stays in Pending state even though it's confirmed in Etherscan #21941

metamaskbot · 2024-01-02T13:44:46Z

No release label at all on PR. Adding release label release-11.7.2 on PR, as PR was added to branch 11.7.2 when release was cut.

metamaskbot · 2024-01-02T13:44:47Z

No release label at all on PR. Adding release label release-11.7.2 on PR, as PR was added to branch 11.7.2 when release was cut.

danjm requested a review from a team as a code owner December 19, 2023 09:10

danjm temporarily deployed to desktop December 19, 2023 09:10 — with GitHub Actions Inactive

metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Dec 19, 2023

danjm requested review from a team as code owners December 19, 2023 10:33

danjm temporarily deployed to desktop December 19, 2023 10:33 — with GitHub Actions Inactive

DDDDDanica temporarily deployed to desktop December 19, 2023 12:46 — with GitHub Actions Inactive

DDDDDanica force-pushed the Version-v11.7.2 branch from bb22634 to 9f2fc87 Compare December 19, 2023 12:48

DDDDDanica temporarily deployed to desktop December 19, 2023 12:48 — with GitHub Actions Inactive

Gudahtt reviewed Dec 19, 2023

View reviewed changes

DDDDDanica temporarily deployed to desktop December 19, 2023 16:24 — with GitHub Actions Inactive

DDDDDanica temporarily deployed to desktop December 19, 2023 16:29 — with GitHub Actions Inactive

matthewwalsh0 and others added 2 commits December 20, 2023 05:07

v11.7.2

622a783

danjm force-pushed the Version-v11.7.2 branch from 1a6d367 to 622a783 Compare December 20, 2023 08:38

danjm temporarily deployed to desktop December 20, 2023 08:38 — with GitHub Actions Inactive

DDDDDanica temporarily deployed to desktop December 20, 2023 14:00 — with GitHub Actions Inactive

DDDDDanica temporarily deployed to desktop December 20, 2023 14:05 — with GitHub Actions Inactive

DDDDDanica temporarily deployed to desktop December 20, 2023 14:10 — with GitHub Actions Inactive

danjm force-pushed the Version-v11.7.2 branch from ba7ff94 to 622a783 Compare December 20, 2023 14:10

danjm temporarily deployed to desktop December 20, 2023 14:11 — with GitHub Actions Inactive

sleepytanya added the QA Passed label Dec 20, 2023

danjm merged commit 6bf6c73 into master Dec 20, 2023

danjm deleted the Version-v11.7.2 branch December 20, 2023 18:44

github-actions bot locked and limited conversation to collaborators Dec 20, 2023

gauthierpetetin added the release-11.7.2 Issue or pull request that will be included in release 11.7.2 label Jan 2, 2024

Conversation

danjm commented Dec 19, 2023

Uh oh!

github-actions bot commented Dec 19, 2023

Uh oh!

socket-security bot commented Dec 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

socket-security bot commented Dec 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Gudahtt commented Dec 19, 2023

Uh oh!

danjm commented Dec 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

metamaskbot commented Dec 20, 2023

Uh oh!

metamaskbot commented Dec 20, 2023

Uh oh!

sleepytanya commented Dec 20, 2023

Uh oh!

metamaskbot commented Jan 2, 2024

Uh oh!

metamaskbot commented Jan 2, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

socket-security bot commented Dec 19, 2023 •

edited

Loading

socket-security bot commented Dec 19, 2023 •

edited

Loading

danjm commented Dec 20, 2023 •

edited

Loading