Closed
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
NidhiKJha
previously approved these changes
Dec 13, 2023
323d4a0 to
050bc98
Compare
chloeYue
previously approved these changes
Dec 13, 2023
NidhiKJha
previously approved these changes
Dec 13, 2023
050bc98 to
ac286d4
Compare
zone-live
approved these changes
Dec 13, 2023
chloeYue
approved these changes
Dec 13, 2023
pedronfigueiredo
approved these changes
Dec 13, 2023
Contributor
Author
|
closed because include in this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix flaky test when sending eth for EIP-1559 transaction. When using slow mode, it can be detected that the estimated fee is changed, which should be like that because we modified priority fee. You can see the quick change at 00:12 in the video attached.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
slow-send-eth-flaky.mp4
After
Pre-merge author checklist
Pre-merge reviewer checklist