Skip to content

fix(000): fix flaky send eth flow#22266

Closed
DDDDDanica wants to merge 1 commit intodevelopfrom
fix/flaky-send-eth
Closed

fix(000): fix flaky send eth flow#22266
DDDDDanica wants to merge 1 commit intodevelopfrom
fix/flaky-send-eth

Conversation

@DDDDDanica
Copy link
Copy Markdown
Contributor

Description

Fix flaky test when sending eth for EIP-1559 transaction. When using slow mode, it can be detected that the estimated fee is changed, which should be like that because we modified priority fee. You can see the quick change at 00:12 in the video attached.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

slow-send-eth-flaky.mp4

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@DDDDDanica DDDDDanica added the team-extension-platform Extension Platform team label Dec 13, 2023
@DDDDDanica DDDDDanica self-assigned this Dec 13, 2023
@DDDDDanica DDDDDanica requested a review from a team as a code owner December 13, 2023 13:29
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

NidhiKJha
NidhiKJha previously approved these changes Dec 13, 2023
@DDDDDanica DDDDDanica force-pushed the fix/flaky-send-eth branch 2 times, most recently from 323d4a0 to 050bc98 Compare December 13, 2023 13:48
chloeYue
chloeYue previously approved these changes Dec 13, 2023
NidhiKJha
NidhiKJha previously approved these changes Dec 13, 2023
@DDDDDanica DDDDDanica dismissed stale reviews from NidhiKJha and chloeYue via ac286d4 December 13, 2023 14:20
@DDDDDanica
Copy link
Copy Markdown
Contributor Author

closed because include in this PR
#22247

@DDDDDanica DDDDDanica closed this Dec 13, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2023
@DDDDDanica DDDDDanica deleted the fix/flaky-send-eth branch December 13, 2023 15:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

team-extension-platform Extension Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants