feat(22244): update pricing api from coingekco to our own ones#22247
Merged
DDDDDanica merged 1 commit intodevelopfrom Dec 13, 2023
Merged
feat(22244): update pricing api from coingekco to our own ones#22247DDDDDanica merged 1 commit intodevelopfrom
DDDDDanica merged 1 commit intodevelopfrom
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
2d4c1ef to
76451c1
Compare
76451c1 to
f3a8f08
Compare
f3a8f08 to
45ebb7e
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #22247 +/- ##
========================================
Coverage 67.74% 67.74%
========================================
Files 1065 1065
Lines 41272 41272
Branches 11065 11065
========================================
Hits 27959 27959
Misses 13313 13313 ☔ View full report in Codecov by Sentry. |
zone-live
approved these changes
Dec 13, 2023
pedronfigueiredo
approved these changes
Dec 13, 2023
Contributor
Author
|
Also include fix in #22266 |
Collaborator
Builds ready [45ebb7e]
Page Load Metrics (1173 ± 135 ms)
Bundle size diffs
|
Collaborator
|
Missing release label release-11.7.3 on PR. Adding release label release-11.7.3 on PR and removing other release labels(release-11.9.0), as PR was cherry-picked in branch 11.7.3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Switch pricing api to our own ones.
Documentation: https://price-api.metafi.codefi.network/docs#/Spot%20Prices/PriceController_getSpotPricesByTokenAddressesV2
Sample request
and previous request:
PS: response body is the same
also fix failing e2e test in
#22266
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist