feat: fetch token fiat amount on import confirmation modal#22263
Merged
sahar-fehri merged 6 commits intodevelopfrom Jan 8, 2024
Merged
feat: fetch token fiat amount on import confirmation modal#22263sahar-fehri merged 6 commits intodevelopfrom
sahar-fehri merged 6 commits intodevelopfrom
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
3 tasks
ac3aad2 to
6dd45b2
Compare
Collaborator
Builds ready [9c32928]
Page Load Metrics (1277 ± 146 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #22263 +/- ##
===========================================
+ Coverage 67.90% 67.91% +0.01%
===========================================
Files 1071 1071
Lines 41378 41407 +29
Branches 11112 11116 +4
===========================================
+ Hits 28095 28120 +25
- Misses 13283 13287 +4 ☔ View full report in Codecov by Sentry. |
fd02720 to
8eb5af9
Compare
Collaborator
Builds ready [d52dd9c]
Page Load Metrics (1224 ± 126 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
DDDDDanica
reviewed
Dec 18, 2023
ui/components/multichain/import-tokens-modal/import-tokens-modal.js
Outdated
Show resolved
Hide resolved
a920a07 to
96a683b
Compare
DDDDDanica
previously approved these changes
Dec 19, 2023
NidhiKJha
previously approved these changes
Dec 19, 2023
9363eea
9363eea to
0dd772e
Compare
Collaborator
Builds ready [0dd772e]
Page Load Metrics (1538 ± 141 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
DDDDDanica
approved these changes
Dec 20, 2023
NidhiKJha
approved these changes
Dec 20, 2023
sahar-fehri
added a commit
to MetaMask/core
that referenced
this pull request
Dec 21, 2023
## Explanation Export a function from assets controller to fetch token exchange rates. This function will be used by extension to compute user token fiat amount and display it on the import token modal confirmation page. ## References * Fixes [#12345](https://consensyssoftware.atlassian.net/browse/MMASSETS-88) * Related to [#67890](MetaMask/metamask-extension#22263) ## Changelog <!-- If you're making any consumer-facing changes, list those changes here as if you were updating a changelog, using the template below as a guide. (CATEGORY is one of BREAKING, ADDED, CHANGED, DEPRECATED, REMOVED, or FIXED. For security-related issues, follow the Security Advisory process.) Please take care to name the exact pieces of the API you've added or changed (e.g. types, interfaces, functions, or methods). If there are any breaking changes, make sure to offer a solution for consumers to follow once they upgrade to the changes. Finally, if you're only making changes to development scripts or tests, you may replace the template below with "None". --> ### `@metamask/assets-controllers` - **<CATEGORY>**: Updated `assetsUtil `file to export `fetchAndMapExchangeRates `function ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've highlighted breaking changes using the "BREAKING" category above as appropriate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The goal of this PR is to fetch user token fiat balance on the import modal confirmation page.
There is an ongoing PR on core to enable this:
MetaMask/core#3657
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/MMASSETS-88
also design wise relates to this PR #21704
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist