fix: 2 Duplicated Signature requests events are triggered for any signature#21955
Merged
fix: 2 Duplicated Signature requests events are triggered for any signature#21955
Conversation
…nature (#21791) ## **Description** When you click on a signature request that is flagged by PPOM, 2 events are sent to metrics instead of 1. ### Expected behavior Just 1 Signature request should be triggered for a Signature event flagged by PPOM ## **Related issues** Fixes: #21770 ## **Manual testing steps** 1. Launch MM 2. Open background console and open the network app, make sure it's recording network requests 3. Open testdapp 4. Click on any of the signature requests for PPOM e.g Malicious Trade Order 5. Go to background console network tab and see 2 signature requests called as shown in the video 6. Checkout this branch, build and run MM 7. Repeat steps 2-4 8. On the background console, you should now see only 1 signature request sent. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** [<!-- [screenshots/recordings] -->](https://github.com/MetaMask/metamask-extension/assets/54408225/926b1da1-deac-45b3-91d9-f55f5da6cbe6) ### **After** https://github.com/MetaMask/metamask-extension/assets/44811/f7f32a58-dcff-4a76-8bdb-6579d6693b88 ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've clearly explained what problem this PR is solving and how it is solved. - [x] I've linked related issues - [x] I've included manual testing steps - [x] I've included screenshots/recordings if applicable - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [x] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [x] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
Builds ready [a3c4c1f]
Page Load Metrics (494 ± 258 ms)
Bundle size diffs
|
jpuri
approved these changes
Nov 23, 2023
blackdevelopa
approved these changes
Nov 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For some reason, this merge is showing this warning on Github

So I cherry picked it to develop and created this new PR.
This is basically a copy and paste of #21791 but this time using develop as base.
Below is the original Description copied over from 21791 for completion
When you click on a signature request that is flagged by PPOM, 2 events are sent to metrics instead of 1.
Expected behavior
Just 1 Signature request should be triggered for a Signature event flagged by PPOM
Related issues
Fixes: #21770
Manual testing steps
Screenshots/Recordings
Before
2-signature-requests.mp4
After
Screen.Recording.2023-11-10.at.10.39.43.mov
Pre-merge author checklist
Pre-merge reviewer checklist