Description

When you click on a signature request that is flagged by PPOM, 2 events are sent to metrics instead of 1.

Expected behavior

Just 1 Signature request should be triggered for a Signature event flagged by PPOM

Related issues

Fixes: #21770

Manual testing steps

1. Launch MM
2. Open background console and open the network app, make sure it's recording network requests
3. Open testdapp
4. Click on any of the signature requests for PPOM e.g Malicious Trade Order
5. Go to background console network tab and see 2 signature requests called as shown in the video
6. Checkout this branch, build and run MM
7. Repeat steps 2-4
8. On the background console, you should now see only 1 signature request sent.

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've clearly explained what problem this PR is solving and how it is solved.
• I've linked related issues
• I've included manual testing steps
• I've included screenshots/recordings if applicable
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
• I’ve properly set the pull request status:
  • In case it's not yet "ready for review", I've set it to "draft".
  • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.