deps: force js-sha3 to ^0.9.2 by resolutions#20921
Merged
HowardBraham merged 2 commits intoMetaMask:developfrom Jan 31, 2024
Merged
deps: force js-sha3 to ^0.9.2 by resolutions#20921HowardBraham merged 2 commits intoMetaMask:developfrom
HowardBraham merged 2 commits intoMetaMask:developfrom
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
No dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No dependency changes detected in pull request |
b573eef to
a02b433
Compare
a02b433 to
4202705
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #20921 +/- ##
===========================================
- Coverage 68.06% 68.05% -0.00%
===========================================
Files 1083 1083
Lines 42520 42520
Branches 11367 11367
===========================================
- Hits 28937 28936 -1
- Misses 13583 13584 +1 ☔ View full report in Codecov by Sentry. |
4202705 to
cdbdeb9
Compare
cdbdeb9 to
d48aef4
Compare
f5f8e76 to
ef2b6ca
Compare
Mrtenz
previously approved these changes
Oct 17, 2023
aa64aed to
50827eb
Compare
671b9a9 to
cf93671
Compare
NEllusion
previously approved these changes
Jan 15, 2024
ac10620 to
1b1aecb
Compare
Contributor
Author
|
Rebased on |
659ae50 to
47cf208
Compare
f30749d to
64a82e1
Compare
Contributor
Author
|
|
NEllusion
approved these changes
Jan 30, 2024
HowardBraham
approved these changes
Jan 31, 2024
Collaborator
|
No release label on PR. Adding release label release-11.11.0 on PR, as PR was added to branch 11.11.0 when release was cut. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Forces legacy transitive dependencies on
js-sha3to latest via yarn resolution.Manual Testing Steps
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Boardlabel.In this case, a QA Engineer approval will be be required.