Description

This PR fixes two related bug reports:

1. @hjetpoluru showed me that add-custom-network.spec.js can have one test crash from a Chrome error, and then the rest of the tests in that file automatically fail with listen EADDRINUSE: address already in use 127.0.0.1:8545
2. @Gudahtt pointed out that if a test gets a Chrome error, it can often retry and succeed, but never close, and then report as a failure to CircleCI

Method to fix:

1. Ignore console errors that start with Warning: as these shouldn't be causing test failures anyway
2. The throw new Error() used to be inside driver.logBrowserError(), but that function is running inside the callback this.driver.onLogEvent(), and not in the main test thread. It now checks for and throws the Error in the main test thread, after await testSuite() but before console.log(`\nSuccess on testcase: '${title}'\n`);.
3. It would previously get the Chrome console errors in the test logs correctly with yarn start:test, but now it supports yarn build:test too (this was an oversight of mine in the past)

Related issues

Manual testing steps

• Harika's testcase: locally run yarn test:e2e:single test/e2e/tests/add-custom-network.spec.js --browser=chrome --debug --leave-running
• @dan437 and @Gudahtt testcase: Make sure it does not repeat these errors:
  https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/67735/workflows/0526cea0-229f-4e20-a4d4-924eb254b1e1/jobs/2231422
  https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/67719/workflows/96dfd8ad-d1c8-4272-ad73-c4c317d11739/jobs/2230668
  https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/67713/workflows/7cf3be9d-aefb-4845-805a-29aa55cd2e28/jobs/2230339
  https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/67692/workflows/0ca31731-d197-4b1d-9d4c-100ddaaf5ea4/jobs/2229290
  https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/67740/workflows/3c079482-e7f6-4ce9-9073-e2ae6f1dc27c/jobs/2231757
  If it gets one console error, then retries and succeeds, it should pass.
• Howard's testcase: tried adding this code to the Unlock page

  if (Math.random() <= 0.1) {
    throw new Error('Deliberate Chrome Error!');
  }
  

  So it fails 10% of the time with 'Deliberate Chrome Error'
  See this run where it hits 'Deliberate Chrome Error', then retries and succeeds:
  https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/67855/workflows/ded22e99-e7e9-4bc2-8fd3-1fd7cd8f2c02/jobs/2237475/parallel-runs/12/steps/12-105

Screenshots/Recordings

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've clearly explained what problem this PR is solving and how it is solved.
• I've linked related issues
• I've included manual testing steps
• I've included screenshots/recordings if applicable
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
• I’ve properly set the pull request status:
  • In case it's not yet "ready for review", I've set it to "draft".
  • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.