Using NetworkAccountBalanceHeader component on SIWE screen by NiranjanaBinoy · Pull Request #19361 · MetaMask/metamask-extension

NiranjanaBinoy · 2023-05-31T20:31:00Z

Explanation

NetworkAccountBalanceHeader is now being shown on the SIWE screen.

Fixes #17812

Screenshots/Screencaps

Before

After

Manual Testing Steps

Go to https://metamask.github.io/test-dapp/
Under Sign In With Ethereum, click on Sign In With Ethereum

Pre-merge author checklist

I've clearly explained:
- What problem this PR is solving
- How this problem was solved
- How reviewers can test my changes
Sufficient automated test coverage has been added

Pre-merge reviewer checklist

Manual testing (e.g. pull and build branch, run in browser, test code being changed)
PR is linked to the appropriate GitHub issue
IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

github-actions · 2023-05-31T20:31:13Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2023-05-31T21:13:57Z

Builds ready [209ef2c]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1560 ± 48 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	91	303	114	44	21
		domContentLoaded	1400	1863	1551	102	49
		load	1400	1864	1560	100	48
		domInteractive	1400	1863	1551	102	49

Bundle size diffs

background: 0 bytes
ui: 3023 bytes
common: 0 bytes

NiranjanaBinoy · 2023-06-01T21:55:16Z

+
+import NetworkAccountBalanceHeader from '../network-account-balance-header';
+
+const SignatureRequestsCommonHeader = ({ txData }) => {


In this PR, I have updated and to use this new component. This can also be used in , which I will be updating in #19104 to reduce redundant work as I am refactoring the component to a functional component in that PR.

metamaskbot · 2023-06-01T22:22:54Z

Builds ready [154394a]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1581 ± 55 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	92	135	110	12	6
		domContentLoaded	1441	1818	1559	110	53
		load	1441	1818	1581	114	55
		domInteractive	1441	1817	1559	110	53

Bundle size diffs

background: 0 bytes
ui: 2355 bytes
common: 0 bytes

jpuri

Some small feedbacks, looks good otherwise 👍

codecov · 2023-06-02T14:37:12Z

Codecov Report

Merging #19361 (8a1aff9) into develop (5355000) will increase coverage by 0.01%.
The diff coverage is 88.00%.

@@             Coverage Diff             @@
##           develop   #19361      +/-   ##
===========================================
+ Coverage    69.98%   69.99%   +0.01%     
===========================================
  Files          959      960       +1     
  Lines        36790    36802      +12     
  Branches      9452     9452              
===========================================
+ Hits         25747    25759      +12     
  Misses       11043    11043

Impacted Files	Coverage Δ
...t-original/signature-request-original.component.js	`52.69% <ø> (-1.77%)`	⬇️
...t-original/signature-request-original.container.js	`74.19% <ø> (-0.09%)`	⬇️
...gnature-request-header/signature-request-header.js	`87.50% <87.50%> (ø)`
...p/signature-request-siwe/signature-request-siwe.js	`65.12% <100.00%> (ø)`

metamaskbot · 2023-06-02T15:19:48Z

Builds ready [7d6c201]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1715 ± 58 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	103	188	134	27	13
		domContentLoaded	1528	1983	1699	121	58
		load	1551	1983	1715	121	58
		domInteractive	1528	1983	1699	121	58

Bundle size diffs

background: 0 bytes
ui: 2227 bytes
common: 0 bytes

metamaskbot · 2023-06-05T22:14:09Z

Builds ready [8a1aff9]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1744 ± 105 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	96	158	127	20	10
		domContentLoaded	1488	2291	1712	192	92
		load	1513	2472	1744	218	105
		domInteractive	1488	2291	1712	192	92

Bundle size diffs

background: 0 bytes
ui: 2227 bytes
common: 0 bytes

updating the SIWE Signature Request to use NetworkAccountBalanceHeader

d55074f

NiranjanaBinoy self-assigned this May 31, 2023

NiranjanaBinoy added type-enhancement area-signatures team-confirmations-secure-ux-PR PRs from the confirmations team labels May 31, 2023

NiranjanaBinoy marked this pull request as ready for review May 31, 2023 20:34

NiranjanaBinoy requested a review from a team as a code owner May 31, 2023 20:34

NiranjanaBinoy requested review from digiwand and jpuri May 31, 2023 20:34

NiranjanaBinoy added 2 commits May 31, 2023 16:41

renaming the hook and removing the commented lines

bd84724

renaming the hook

209ef2c

jpuri reviewed Jun 1, 2023

View reviewed changes

Comment thread ui/hooks/useSignatureRequestHeaderData.js

NiranjanaBinoy added 3 commits June 1, 2023 15:14

replacing the hook with compoenent as it is returning JSX

d1af863

replacing the hook with compoenent as it is returning JSX

9bc24ac

adding test and stories for the new component

8fda6d3

NiranjanaBinoy requested a review from jpuri June 1, 2023 21:40

NiranjanaBinoy mentioned this pull request Jun 1, 2023

Signature-Request refactor #19104

Merged

8 tasks

Merge branch 'develop' into siwe-network-account-balance-header

154394a

NiranjanaBinoy commented Jun 1, 2023

View reviewed changes

segun reviewed Jun 2, 2023

View reviewed changes

Comment thread ui/components/app/signature-request-original/signature-request-original.component.js Outdated

jpuri reviewed Jun 2, 2023

View reviewed changes

Comment thread ui/components/app/signature-request-original/signature-request-original.component.js Outdated

jpuri reviewed Jun 2, 2023

View reviewed changes

Comment thread ui/components/app/signature-requests-common-header/index.js Outdated

jpuri reviewed Jun 2, 2023

View reviewed changes

Comment thread ui/components/app/signature-requests-common-header/signature-requests-common-header.js

jpuri reviewed Jun 2, 2023

View reviewed changes

Comment thread ui/components/app/signature-requests-common-header/signature-requests-common-header.js Outdated

jpuri previously approved these changes Jun 2, 2023

View reviewed changes

updating review comments

7d6c201

NiranjanaBinoy dismissed jpuri’s stale review via 7d6c201 June 2, 2023 14:34

jpuri approved these changes Jun 2, 2023

View reviewed changes

NiranjanaBinoy requested a review from segun June 5, 2023 12:56

segun approved these changes Jun 5, 2023

View reviewed changes

Merge branch 'develop' into siwe-network-account-balance-header

8a1aff9

NiranjanaBinoy merged commit b5b3f67 into develop Jun 6, 2023

NiranjanaBinoy deleted the siwe-network-account-balance-header branch June 6, 2023 13:53

github-actions Bot locked and limited conversation to collaborators Jun 6, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Using NetworkAccountBalanceHeader component on SIWE screen#19361

Using NetworkAccountBalanceHeader component on SIWE screen#19361
NiranjanaBinoy merged 9 commits intodevelopfrom
siwe-network-account-balance-header

NiranjanaBinoy commented May 31, 2023 •

edited

Loading

Uh oh!

github-actions Bot commented May 31, 2023

Uh oh!

metamaskbot commented May 31, 2023

Uh oh!

Uh oh!

NiranjanaBinoy Jun 1, 2023

Uh oh!

metamaskbot commented Jun 1, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jpuri left a comment

Uh oh!

codecov Bot commented Jun 2, 2023 •

edited

Loading

Uh oh!

metamaskbot commented Jun 2, 2023

Uh oh!

metamaskbot commented Jun 5, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants


		import NetworkAccountBalanceHeader from '../network-account-balance-header';

		const SignatureRequestsCommonHeader = ({ txData }) => {

Conversation

NiranjanaBinoy commented May 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation

Screenshots/Screencaps

Before

After

Manual Testing Steps

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions Bot commented May 31, 2023

Uh oh!

metamaskbot commented May 31, 2023

Uh oh!

Uh oh!

NiranjanaBinoy Jun 1, 2023

Choose a reason for hiding this comment

Uh oh!

metamaskbot commented Jun 1, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jpuri left a comment

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Jun 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

metamaskbot commented Jun 2, 2023

Uh oh!

metamaskbot commented Jun 5, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

NiranjanaBinoy commented May 31, 2023 •

edited

Loading

codecov Bot commented Jun 2, 2023 •

edited

Loading