Closed
Conversation
When fetching address in other network, query address with the chainId converted into the coinType
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Wallyworldg02
previously approved these changes
Mar 14, 2023
Codecov Report
@@ Coverage Diff @@
## develop #18035 +/- ##
===========================================
- Coverage 64.01% 63.98% -0.03%
===========================================
Files 918 919 +1
Lines 35310 35329 +19
Branches 8993 9000 +7
===========================================
+ Hits 22602 22603 +1
- Misses 12708 12726 +18
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This was referenced Apr 18, 2023
Contributor
|
This PR has been automatically marked as stale because it has not had recent activity in the last 60 days. It will be closed in 14 days. Thank you for your contributions. |
Contributor
|
This PR was closed because there has been no follow up activity in the last 14 days. Thank you for your contributions. |
7 tasks
mirceanis
added a commit
that referenced
this pull request
Sep 18, 2024
…esolver snap (#26242) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> The embedded ENS resolution logic is being replaced by snaps that use `endowment:name-lookup`. This change-set also includes a preinstalled snap that does ENS resolution including ENS multi-coin functionality. The ENS resolver snap will use the Ethereum provider from the extension on Ethereum mainnet and ENS supported testnets and will revert to an Infura JSON-RPC when the extension is connected to other networks. On other networks it tries to resolve the [network-specific ENS address](https://eips.ethereum.org/EIPS/eip-2304) and if none exists will try to resolve the mainnet address (with a⚠️ warning) as long as that address appears to be an externally owned account. Most of the relevant changes are in `domains.js`. Since the preinstalled snap uses ethers v6 while the extension depends on ethers v5.7 there are some changes in the lavamoat policies. Also, the more recent ethers version requires a different set of mocks, requiring a small change in the e2e test. [](https://codespaces.new/MetaMask/metamask-extension/pull/26242?quickstart=1) ## **Related issues** fixes https://github.com/MetaMask/MetaMask-planning/issues/2403 closes #18035 fixes #18648 fixes #22797 fixes #8556 fixes MetaMask/specifications#11 ## **Manual testing steps** 1. While on Ethereum mainnet, start a send flow 2. Type an ENS name in the recipient field(example _vitalik.eth_), pick the resulting address. (this should be identical to previous behavior) 3. Switch to a L2 4. Type an EOA ENS name in the recipient field (example _vitalik.eth_), observe an address being resolved with a⚠️ warning. 5. Type an ENS name that would resolve to a contract on mainnet (example _uniswap.eth_). Observe `No resolution for domain provided.` error. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> https://github.com/user-attachments/assets/6e8866ef-f478-4647-a0f0-f1c13342edd1 ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Signed-off-by: Mircea Nistor <mirceanis@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
This PR is to resolve MetaMask/specifications#11
Screenshots/Screencaps
Before
After
OPaddress on Optimism networkManual Testing Steps
When Metamask was connected to Mainnet, looking up
matoken.ethshould return 0x5aWhen Metamask was connected to Mainnet, looking up
makoto.ethshould return 0xfFDWhen Metamask was connected to Mainnet, looking up
0xmatoken.ethshould returnno address has been set for this nameWhen Metamask was connected to Testnet (Goerli), looking up
makoto.ethshould returnno address has been set for this nameWhen Metamask was connected to Testnet (Goerli), looking up
0xmatoken.ethshould return 0x5aWhen Metamask was connected to Other network(eg: OP), looking up
matoken.ethshould returnno address has been set for this nameWhen Metamask was connected to Other network(eg: OP), looking up
bertho.ethshould return0x837Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Boardlabel.In this case, a QA Engineer approval will be be required.