Skip to content

Onboarding V2: Fix 'Securing my Wallet' when coming from backup reminder after account recovery#17088

Merged
ryanml merged 1 commit intodevelopfrom
fix-17025
Jan 6, 2023
Merged

Onboarding V2: Fix 'Securing my Wallet' when coming from backup reminder after account recovery#17088
ryanml merged 1 commit intodevelopfrom
fix-17025

Conversation

@ryanml
Copy link
Copy Markdown
Contributor

@ryanml ryanml commented Jan 5, 2023

Fixes: #17025

Explanation

This expands on a fix implemented in #16916

The isFromReminder parameter needs to persist in a couple of places when coming from the backup reminder in order to complete the backup flow.

Screenshots/Screencaps

onboarding-fix.mov

Manual Testing Steps

  1. Perform all the Onboarding V2 for Create Account without securing the seed phrase
  2. Lock MM
  3. Click Forgot Password
  4. Add a Seed Phrase and Password
  5. Login
  6. Click on the Backup reminder from Home page
  7. Click on Secure my Wallet
  8. Ensure you can complete the backup process as expected

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@ryanml ryanml requested a review from a team as a code owner January 5, 2023 21:50
@ryanml ryanml self-assigned this Jan 5, 2023
@ryanml ryanml requested a review from danjm January 5, 2023 21:50
@ryanml
Copy link
Copy Markdown
Contributor Author

ryanml commented Jan 5, 2023

Note: The backup reminder is present after creating a fresh account in the video of the fix due to a temporary change I made in my branch for testing (Removed the check for account balance)

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jan 5, 2023

Builds ready [d4cbff6]
Page Load Metrics (1349 ± 98 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint91136104126
domContentLoaded11181749131819091
load11181817134920498
domInteractive11181749131819091
Bundle size diffs
  • background: 0 bytes
  • ui: 228 bytes
  • common: 0 bytes

highlights:

storybook

danjm
danjm approved these changes Jan 5, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@danjm danjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryanml ryanml merged commit e8809cf into develop Jan 6, 2023
@ryanml ryanml deleted the fix-17025 branch January 6, 2023 06:14
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2023
@seaona seaona added this to the v10.24.0 milestone Jan 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jpuri jpuri jpuri approved these changes

+1 more reviewer

@danjm danjm danjm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ryanml ryanml

Labels

rc-cherry-picked

Projects

None yet

Milestone

v10.24.0

Development

Successfully merging this pull request may close these issues.

[Bug]: Onboarding V2 Securing my Wallet lands me to Home instead of the Backup Seed phrase page when I come from Forgot Password flow

6 participants

@ryanml @metamaskbot @jpuri @danjm @PeterYinusa @seaona