Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
efd6cdf to
83c7962
Compare
03ef35a to
be158c8
Compare
be158c8 to
28ea4c9
Compare
Contributor
|
Shouldn't the user be able to go back for e.g. enabling/disabling MetaMetrics in case they click the wrong button there or want to go back/change their mind before completion? |
digiwand
reviewed
Dec 13, 2022
eaa260c to
134f878
Compare
Contributor
Author
All of the preferences we allow users to provide during onboarding can be found in settings if users wish to modify them:
cc @legobeat |
Collaborator
Builds ready [134f878]
Page Load Metrics (2284 ± 105 ms)
Bundle size diffs
|
jpuri
approved these changes
Dec 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue where the secret recovery phrase state is not available when navigating back after completing onboarding. We now prevent users from navigating back into the onboarding flow at all after its completion. The one exception is when you click the
Backup Nowbutton on theBackup your Secret Recovery Phrase to keep your wallet and funds secure.reminder if you opted to not reveal and back up the security phrase in the initial onboarding flow.Before
206736619-6f631afd-e96f-4eb8-8ed5-e94086a01be2.mp4
and backup reminder button takes us to V1 secure seedphrase flow instead of V2 even when feature flag is on:
https://user-images.githubusercontent.com/34557516/207154103-5e38e796-c18c-4ece-bf9d-a7b4c56f7ff6.mov
After
See you cannot navigate back after completing onboarding but you are able to navigate back to secure your wallet if you did not do so initially (the reminder here is hardcoded to show up immediately for demonstration purposes).
https://user-images.githubusercontent.com/34557516/207164461-1e6ea62d-6e5e-4538-8b9e-3f794188bc62.mov
Manual Testing Steps
Pre-merge author checklist