Adding edit navigation button flow back to send token flow#11335
Merged
Adding edit navigation button flow back to send token flow#11335
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
ff3f046 to
e36b138
Compare
52d82ec to
3ec9d68
Compare
e36b138 to
8722722
Compare
1a75bfa to
ceaa0be
Compare
8722722 to
5065ca3
Compare
7001442 to
fafc37d
Compare
adonesky1
commented
Jun 18, 2021
ui/ducks/send/send.js
Outdated
| state.draftTransaction.id = action.payload.id; | ||
| state.draftTransaction.txParams.from = action.payload.from; | ||
| slice.caseReducers.updateDraftTransaction(state); | ||
| if(state.asset.type === ASSET_TYPES.NATIVE){ |
Contributor
Author
There was a problem hiding this comment.
@brad-decker can we take a look at this PR together sometime today? I've spent too much time trying to figure out whats going wrong. The navigate back to edit flow is behaving inconsistently for me
fe6d9da to
1df28f2
Compare
1df28f2 to
844606b
Compare
fafc37d to
ee5d021
Compare
581597d to
849ca6a
Compare
2803d5c to
8120baa
Compare
Contributor
Author
|
@brad-decker with the fix you added for the gasLoading issue this PR appears to be working as I expect it to. Take a look when you have chance? |
Collaborator
Builds ready [8120baa]
Page Load Metrics (627 ± 34 ms)
|
8120baa to
d302637
Compare
brad-decker
approved these changes
Jun 23, 2021
Contributor
brad-decker
left a comment
There was a problem hiding this comment.
💯 works like a charm!
Collaborator
Builds ready [d302637]
Page Load Metrics (546 ± 41 ms)
|
danjm
approved these changes
Jun 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #11317
Explanation: While reviewing @brad-decker send slice refactor PR I found invalid logic around editing a transaction in the send flow where the recipient address and amount were switched. Upon further digging I realized this wasn't causing a visible issue because the (back to) edit option that is available for ETH transactions is not available for token transactions (where this logic would be used). This PR adds back the edit navigation button for the send-token flow and fixes the faulty logic.
Manual testing steps: