Describe the bug
While reviewing @brad-decker send slice refactor PR I found some invalid logic around editing a transaction in the send flow where the recipient address and amount were switched. Upon further digging I realized this wasn't causing a visible issue because the (back to) edit option that is available for ETH transactions is not available for token transactions (where this logic would be used). I don't believe there is a good reason that we should allow users to return to edit a transaction in the ETH send flow but not in a token send flow?
Steps to reproduce (REQUIRED)
- Start to send a token (on any network, and token that is not its native asset)
- Once at the confirm screen look for the edit button in the top left corner and see that it isn't present
Expected behavior
Users should be able to navigate back to edit a transaction while sending a token.
Screenshots
If applicable, add screenshots to help explain your problem.
Browser details (please complete the following information):
- OS: OSX
- Browser: Chrome
- MetaMask Version: 9.6.0
Describe the bug
While reviewing @brad-decker send slice refactor PR I found some invalid logic around editing a transaction in the send flow where the recipient address and amount were switched. Upon further digging I realized this wasn't causing a visible issue because the (back to) edit option that is available for ETH transactions is not available for token transactions (where this logic would be used). I don't believe there is a good reason that we should allow users to return to edit a transaction in the ETH send flow but not in a token send flow?
Steps to reproduce (REQUIRED)
Expected behavior
Users should be able to navigate back to edit a transaction while sending a token.
Screenshots
If applicable, add screenshots to help explain your problem.
Browser details (please complete the following information):