Refactoring metamask-responsive-ui.spec.js to use fixtures #10866
Refactoring metamask-responsive-ui.spec.js to use fixtures #10866NiranjanaBinoy merged 9 commits intodevelopfrom
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Gudahtt
left a comment
There was a problem hiding this comment.
Could this be split up into 3 different tests? It seems to be testing 3 distinct things: The onboarding 'create wallet' flow, the import from lock screen flow, and the send flow. Except all with a reduced screen size.
Builds ready [6170778]
Page Load Metrics (650 ± 25 ms)
|
6170778 to
caee9bb
Compare
Builds ready [caee9bb]
Page Load Metrics (562 ± 42 ms)
|
Builds ready [711111e]
Page Load Metrics (792 ± 111 ms)
|
Gudahtt
left a comment
There was a problem hiding this comment.
Looks good! Couple of nits but nothing important really. Unfortunately another conflict has been introduced though, as a result of #10852. The web driver refactoring is finished now though so that should be the last time this happens thankfully!
| ); | ||
| }); | ||
|
|
||
| it('Importing existing wallet from login page', async function () { |
There was a problem hiding this comment.
Nit: we've been calling this the "lock" page (unlock/lock), instead of the "login" page
| it('Importing existing wallet from login page', async function () { | |
| it('Importing existing wallet from lock page', async function () { |
|
|
||
| // Show account information | ||
| // show account details dropdown menu | ||
| await driver.clickElement( |
There was a problem hiding this comment.
Nit: I'm not sure how useful this part is, or the lock step at the end 🤔 I guess we need to do something after the account is created, to verify that it worked. Checking the balance would suffice though - that's what we do in the other flow.
There was a problem hiding this comment.
I had the same thought while working on it, then decided to update it based on the review comments 😅
| await driver.wait(until.elementTextMatches(balance, /100\s*ETH/u)); | ||
|
|
||
| // logs out of the vault | ||
| await driver.clickElement('.account-menu__icon'); |
There was a problem hiding this comment.
Nit: This step of logging out of the vault doesn't seem necessary for testing that the onboarding worked.
b09c400 to
019189e
Compare
93e9dfb to
8ae170b
Compare
1ec3bcf to
09ad199
Compare
Builds ready [09ad199]
Page Load Metrics (583 ± 34 ms)
|
Fixes: #10863
Explanation: