Merged
Conversation
108a021 to
fcee942
Compare
Collaborator
Builds ready [fcee942]
Page Load Metrics (585 ± 50 ms)
|
Gudahtt
reviewed
Apr 9, 2021
Member
Gudahtt
left a comment
There was a problem hiding this comment.
LGTM! Apart from the conflicts. I can re-review after those are resolved.
fcee942 to
1a9f286
Compare
1a9f286 to
467121c
Compare
Collaborator
Builds ready [467121c]
Page Load Metrics (634 ± 57 ms)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to improve the abstraction around sending keystrokes/values to input fields. The API aims to match playwright's implementation to allow a more straightforward migration in the near future. There are a few pieces:
.pressdriver.fillAPI to the driver that matches playwright'sfillmethod. Fill differs fromsendKeysin that it replaces the current value instead of adding to it.driver.pressAPI to the driver that matches playwright'spressmethod. Playwright's implementation differs in that it expects key names like 'Enter' while selenium's expects unicode encoded key values.fillandpressmethods.This PR includes the refactor to use these.