Update the changelog when creating an RC#10795
Merged
Conversation
Member
Author
|
|
Collaborator
Builds ready [e0bf1cc]
Page Load Metrics (665 ± 62 ms)
|
5ed8808 to
ddfd922
Compare
e0bf1cc to
e7c7055
Compare
Collaborator
Builds ready [e7c7055]
Page Load Metrics (549 ± 43 ms)
|
Base automatically changed from
add-release-header-when-updating-changelog
to
develop
April 1, 2021 23:39
e7c7055 to
79b8ed5
Compare
Collaborator
Builds ready [79b8ed5]
Page Load Metrics (559 ± 37 ms)
|
79b8ed5 to
0402931
Compare
Collaborator
Builds ready [0402931]
Page Load Metrics (571 ± 40 ms)
|
rekmarks
requested changes
Apr 2, 2021
Member
rekmarks
left a comment
There was a problem hiding this comment.
Looks good except for a typo.
The changelog will now be automatically updated when a release branch is created. A new release header along with changelog entries for any new commits will be added. Note that this changelog will still need to be manually cleaned up, but it's one less manual step at least. The old Bash script for adding a new release header to the changelog has been removed, as that functionality is now built into the changelog update script. A new script has been added to commit any changes made to the manifest and changelog. This step used to happen at the end of the bump manifest version script, but now the changelog update relies upon the manifest version bump happening first, so it needed to be re-ordered. The changes should only be committed on the first run of the branch, as it's contingent upon the manifest changing (due to the version bump). Further changelog updates won't trigger new automatic commits.
0402931 to
02ad6c8
Compare
Member
Author
|
I've just created the branch |
Member
|
ffffuuuuuuu |
The check for manifest changes was wrong on two counts. Firstly it was supposed to check that there *are* changes, but instead it was bailing if there were *no* changes (the opposite of what was intended). Second, it was including changelog changes as well, when it should have only considered manifest changes.
rekmarks
reviewed
Apr 2, 2021
Member
Author
|
It worked! d6b5abd ... after fixing a couple more mistakes 😅 . I put each bug fix in a separate commit - check out the most recent two since your approval to see what they were. |
Member
Author
|
That status check shouldn't affect this PR thankfully, because this isn't a release branch. It was only triggered because this commit was used in a release branch. GitHub applies these status checks by commit it seems, not by branch. |
Collaborator
Builds ready [c6c5daa]
Page Load Metrics (513 ± 38 ms)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changelog will now be automatically updated when a release branch is created. A new release header along with changelog entries for any new commits will be added.
Note that this changelog will still need to be manually cleaned up, but it's one less manual step at least.
The old Bash script for adding a new release header to the changelog has been removed, as that functionality is now built into the changelog update script.
A new script has been added to commit any changes made to the manifest and changelog. This step used to happen at the end of the bump manifest version script, but now the changelog update relies upon the manifest version bump happening first, so it needed to be re-ordered. The changes should only be committed on the first run of the branch, as it's contingent upon the manifest changing (due to the version bump). Further changelog updates won't trigger new automatic commits.
Relates to #10752
Manual testing steps: