Skip to content

Add release header when updating changelog#10794

Merged
Gudahtt merged 1 commit intodevelopfrom
add-release-header-when-updating-changelog
Apr 1, 2021
Merged

Add release header when updating changelog#10794
Gudahtt merged 1 commit intodevelopfrom
add-release-header-when-updating-changelog

Conversation

@Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Apr 1, 2021

The changelog update script now adds a release header if it doesn't find one already that matches the current release candidate version.

Relates to #10752

Manual testing steps:

For development changelog updates:

  • Run yarn update-changelog
  • See that it places changelog entries under 'Current Develop Branch'

For RC changelog updates with existing release header:

  • Bump the version in app/manifest/_base.json, to simulate an RC-like environment
  • Add a new release header to the changelog for the new version
  • Run yarn update-changelog
  • See that it places changelog entries under the new release header

For updates without a release header:

  • Bump the version in app/manifest/_base.json, to simulate an RC-like environment
  • Run yarn update-changelog
  • See that it places changelog entries under the newly added release header

@Gudahtt
Copy link
Member Author

Gudahtt commented Apr 1, 2021

This depends upon #10786

@Gudahtt Gudahtt force-pushed the add-release-header-when-updating-changelog branch from cc23a33 to 5ed8808 Compare April 1, 2021 13:18
@metamaskbot
Copy link
Collaborator

Builds ready [5ed8808]
Page Load Metrics (630 ± 61 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint46846294
domContentLoaded36784262912862
load36984363012861
domInteractive36784162912862

@Gudahtt Gudahtt force-pushed the prevent-duplicate-changelog-entries branch from 74e6a68 to 2baac2a Compare April 1, 2021 14:59
Base automatically changed from prevent-duplicate-changelog-entries to develop April 1, 2021 15:24
The changelog update script now adds a release header if it doesn't
find one already that matches the current release candidate version.
@Gudahtt Gudahtt force-pushed the add-release-header-when-updating-changelog branch from 5ed8808 to ddfd922 Compare April 1, 2021 15:28
@Gudahtt Gudahtt marked this pull request as ready for review April 1, 2021 15:29
@Gudahtt Gudahtt requested review from a team and kumavis as code owners April 1, 2021 15:29
@Gudahtt Gudahtt requested a review from danjm April 1, 2021 15:29
@metamaskbot
Copy link
Collaborator

Builds ready [ddfd922]
Page Load Metrics (565 ± 48 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint44705774
domContentLoaded3836805649948
load38468856510048
domInteractive3836795639948

Copy link
Contributor

@brad-decker brad-decker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gudahtt Gudahtt merged commit 5b5a4f6 into develop Apr 1, 2021
@Gudahtt Gudahtt deleted the add-release-header-when-updating-changelog branch April 1, 2021 23:39
@github-actions github-actions bot locked and limited conversation to collaborators Apr 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants