Skip to content

Version v9.1.1 RC#10574

Merged
Gudahtt merged 4 commits intomasterfrom
Version-v9.1.1
Mar 4, 2021
Merged

Version v9.1.1 RC#10574
Gudahtt merged 4 commits intomasterfrom
Version-v9.1.1

Conversation

@metamaskbot
Copy link
Copy Markdown
Collaborator

📦 🚀

metamaskbot and others added 3 commits March 3, 2021 19:07
* fix: handle safeLow undefined

fixes #10558

* fix: add tests for isCustomGasPriceSafe selector
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 3, 2021

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Copy Markdown
Collaborator Author

Builds ready [d034adf]
Page Load Metrics (640 ± 21 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint468460105
domContentLoaded5817216384321
load5827226404321
domInteractive5807206384321

@metamaskbot
Copy link
Copy Markdown
Collaborator Author

Builds ready [996e8e7]
Page Load Metrics (570 ± 35 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint43705473
domContentLoaded3626415687235
load3636425707235
domInteractive3616405687235

@brad-decker brad-decker marked this pull request as ready for review March 3, 2021 20:34
@brad-decker brad-decker requested a review from a team as a code owner March 3, 2021 20:34
@brad-decker brad-decker self-requested a review March 3, 2021 20:34
Copy link
Copy Markdown
Contributor

@tmashuang tmashuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I think the #10560 reproduction was on the add recipient screen rather than the send screen. Edit: it is in both.

Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt merged commit 0523e9f into master Mar 4, 2021
@Gudahtt Gudahtt deleted the Version-v9.1.1 branch March 4, 2021 01:50
@github-actions github-actions bot locked and limited conversation to collaborators Mar 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants