Skip to content

Fix/handle safe low undefined#10561

Merged
shanejonas merged 2 commits intodevelopfrom
fix/handle-safeLow-undefined
Mar 2, 2021
Merged

Fix/handle safe low undefined#10561
shanejonas merged 2 commits intodevelopfrom
fix/handle-safeLow-undefined

Conversation

@shanejonas
Copy link
Copy Markdown
Contributor

Fixes: #10558

Explanation:

basicEstimates.safeLow can possibly be undefined

Manual testing steps:

  • speed up a cancelled transaction on a custom network surfaces this error

@shanejonas shanejonas requested a review from a team as a code owner March 2, 2021 21:53
@shanejonas shanejonas requested a review from darkwing March 2, 2021 21:53
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 2, 2021

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@shanejonas shanejonas requested a review from Gudahtt March 2, 2021 21:55
@shanejonas shanejonas force-pushed the fix/handle-safeLow-undefined branch from 5368b9a to f8a3e91 Compare March 2, 2021 21:58
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great find!

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [f8a3e91]
Page Load Metrics (613 ± 22 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint46906194
domContentLoaded5037306124522
load5047316134622
domInteractive5027306114522

@shanejonas shanejonas merged commit d44c4d3 into develop Mar 2, 2021
@shanejonas shanejonas deleted the fix/handle-safeLow-undefined branch March 2, 2021 22:19
@github-actions github-actions bot locked and limited conversation to collaborators Mar 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BigNumber Error: new BigNumber() not a number: undefined

3 participants