Implement Ledger Live bridge#10293
Merged
darkwing merged 33 commits intoMetaMask:developfrom Apr 26, 2021
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
darkwing
commented
Jan 27, 2021
ui/app/pages/create-account/connect-hardware/select-hardware.js
Outdated
Show resolved
Hide resolved
darkwing
commented
Jan 27, 2021
ui/app/pages/create-account/connect-hardware/select-hardware.js
Outdated
Show resolved
Hide resolved
darkwing
commented
Jan 27, 2021
darkwing
commented
Jan 27, 2021
Gudahtt
reviewed
Feb 2, 2021
5b1d985 to
aaf6cc7
Compare
darkwing
commented
Feb 11, 2021
087b05e to
819ad7c
Compare
Gudahtt
reviewed
Feb 17, 2021
bd51df0 to
55d68bb
Compare
Gudahtt
reviewed
Feb 23, 2021
050bfd3 to
1d61202
Compare
brad-decker
suggested changes
Mar 3, 2021
Contributor
|
I just spent some time using this and it works like a dream on my Mac in Chrome. 😍 |
Contributor
|
we should probably throw the "DO NOT MERGE" label on this until the reference to your fork for eth-ledger-bridge-keyring is updated to the new version of that library. |
Contributor
Author
|
Hello @rachelcope . Screenshots as promised. I did have to slightly change the text because we need to accommodate this feature being (1) turned on by the user and (2) turned off, thus the old way. "Connect Hardware" with nothing selected
Trezor selected
Ledger selected, new Ledger Live turned on
Ledger with Ledger Live off
|
Contributor
Author
|
This last commit is a reordering of commits to not conflict with @NiranjanaBinoy's |
brad-decker
approved these changes
Apr 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supercedes #10171
This depends upon:
Todo: