Skip to content

Add new ledger live bridge#54

Merged
darkwing merged 38 commits intoMetaMask:gh-pagesfrom
darkwing:gh-pages
May 12, 2021
Merged

Add new ledger live bridge#54
darkwing merged 38 commits intoMetaMask:gh-pagesfrom
darkwing:gh-pages

Conversation

@darkwing
Copy link
Contributor

@darkwing darkwing commented Jan 26, 2021

Supercedes #51

Adds:

  • Logging
  • Missing package.json

Before merging:

  • Remove logging

@darkwing darkwing mentioned this pull request Jan 26, 2021
Closed
darkwing
darkwing commented Jan 26, 2021
View reviewed changes
@darkwing darkwing force-pushed the gh-pages branch 4 times, most recently from 3458fa6 to 4e0a5d8 Compare January 28, 2021 15:42
@danfinlay
Copy link
Contributor

danfinlay commented Jan 29, 2021

Does this interfere with how older versions work (which will still point at this gh-pages iframe)?

@darkwing
Copy link
Contributor Author

darkwing commented Jan 29, 2021

Does this interfere with how older versions work (which will still point at this gh-pages iframe)?

It's designed not to; we have a USE_LIVE constant in here for testing purposes, but we've added an advanced setting in MM which we'll filter down into this PR.

@mimunzar
Copy link

mimunzar commented Feb 1, 2021

Hello guys,

Why are you using http-transport when it is according to their Github page not meant for production? Thanks.

@darkwing darkwing force-pushed the gh-pages branch 11 times, most recently from 42c35bc to 475d74e Compare February 11, 2021 15:25
@darkwing darkwing force-pushed the gh-pages branch 2 times, most recently from 970d087 to bf09368 Compare February 18, 2021 20:41
@darkwing darkwing marked this pull request as draft February 18, 2021 20:49
@darkwing darkwing force-pushed the gh-pages branch 7 times, most recently from 5b2784c to b7b1a68 Compare February 19, 2021 16:16
Gudahtt
Gudahtt reviewed Mar 3, 2021
View reviewed changes
@darkwing darkwing force-pushed the gh-pages branch 4 times, most recently from 330042b to 2fcf4eb Compare March 18, 2021 16:33
darkwing
darkwing commented Mar 23, 2021
View reviewed changes
Gudahtt
Gudahtt reviewed Apr 14, 2021
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good! Once the debugging stuff is removed and the duplicate lockfile is removed, I can approve.

Gudahtt
Gudahtt reviewed Apr 19, 2021
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think package-lock.json needs to be updated. It had changes when I ran npm install locally

Gudahtt
Gudahtt approved these changes Apr 19, 2021
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@darkwing darkwing merged commit e95332a into MetaMask:gh-pages May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@darkwing @danfinlay @mimunzar @Gudahtt @PatrykLucka