Skip to content

Version v9.0.2 RC#10218

Merged
rekmarks merged 6 commits intomasterfrom
Version-v9.0.2
Jan 20, 2021
Merged

Version v9.0.2 RC#10218
rekmarks merged 6 commits intomasterfrom
Version-v9.0.2

Conversation

@metamaskbot
Copy link
Copy Markdown
Collaborator

@metamaskbot metamaskbot commented Jan 20, 2021

📦 🚀

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 20, 2021

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Copy Markdown
Collaborator Author

metamaskbot commented Jan 20, 2021

Builds ready [cfd4422]
Page Load Metrics (523 ± 32 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint316148105
domContentLoaded3345855226732
load3355875236732
domInteractive3335855216732

@rekmarks rekmarks dismissed a stale review via 118281b January 20, 2021 18:43
@rekmarks rekmarks marked this pull request as ready for review January 20, 2021 19:07
@rekmarks rekmarks requested a review from a team as a code owner January 20, 2021 19:07
@rekmarks rekmarks requested a review from danjm January 20, 2021 19:07
@metamaskbot
Copy link
Copy Markdown
Collaborator Author

metamaskbot commented Jan 20, 2021

Builds ready [d0fa2a5]
Page Load Metrics (527 ± 54 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint326649105
domContentLoaded33566452611254
load33666552711254
domInteractive33466352511254

rekmarks
rekmarks approved these changes Jan 20, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM.

Gudahtt
Gudahtt approved these changes Jan 20, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I tested #10219 by creating a branch of our test dapp to test with: https://github.com/MetaMask/test-dapp/compare/missing-data-event-repro?expand=1

With that branch, I was able to verify that it it was broken on v9.0.1, but is working on v9.0.2

@rekmarks rekmarks merged commit ef1b6a7 into master Jan 20, 2021
@rekmarks rekmarks deleted the Version-v9.0.2 branch January 20, 2021 21:43
@github-actions github-actions bot locked and limited conversation to collaborators Jan 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

@rekmarks rekmarks rekmarks approved these changes

@danjm danjm Awaiting requested review from danjm

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@metamaskbot @Gudahtt @rekmarks @gasolin @yahsinhuangtw