Skip to content

Update italian translation#10126

Merged
Gudahtt merged 2 commits intoMetaMask:developfrom
matteopey:italian-translation-update
Mar 4, 2021
Merged

Update italian translation#10126
Gudahtt merged 2 commits intoMetaMask:developfrom
matteopey:italian-translation-update

Conversation

@matteopey
Copy link
Copy Markdown
Contributor

@matteopey matteopey commented Dec 28, 2020

Fixes: -

Explanation: Italian translation

@matteopey matteopey requested a review from a team as a code owner December 28, 2020 14:43
@matteopey matteopey requested a review from danjm December 28, 2020 14:43
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 28, 2020

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Gudahtt Gudahtt force-pushed the italian-translation-update branch from 68aac9d to 01d52e6 Compare January 25, 2021 18:33
@Gudahtt
Copy link
Copy Markdown
Member

Gudahtt commented Jan 25, 2021

The build was failing due to an old security advisory that was already resolved. I've rebased this onto develop to get it working again.

@Gudahtt Gudahtt force-pushed the italian-translation-update branch from 01d52e6 to 87dd575 Compare February 2, 2021 14:43
@Gudahtt
Copy link
Copy Markdown
Member

Gudahtt commented Feb 2, 2021

This PR has been rebased onto develop to ensure that the yourSigRequested message was not present (it was removed in #10300).

@Gudahtt Gudahtt force-pushed the italian-translation-update branch from 87dd575 to 793cc67 Compare February 15, 2021 21:37
@Gudahtt
Copy link
Copy Markdown
Member

Gudahtt commented Feb 15, 2021

I've rebased this on develop to remove another message that was deleted (swapGetQuotes).

jacobc-eth
jacobc-eth reviewed Feb 27, 2021
View reviewed changes
jacobc-eth
jacobc-eth reviewed Feb 27, 2021
View reviewed changes
Copy link
Copy Markdown

@jacobc-eth jacobc-eth left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great! there we just a couple small issues I noticed if you wouldn't mind reviewing those @matteopey

disclaimer: I'm an Italian-American whose mastery of Italian is not good at all, so sorry if I made any mistake :)

@matteopey
Copy link
Copy Markdown
Contributor Author

matteopey commented Feb 27, 2021

@jacobcantele thanks very much for the review! I updated it and also added latest translations.

@matteopey matteopey force-pushed the italian-translation-update branch from 561fcfc to 50d492d Compare February 27, 2021 15:15
Gudahtt
Gudahtt approved these changes Mar 4, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jacobcantele has communicated to me that this is ready to merge 🎉
Thanks again @matteopey! and @jacobcantele for the review

@Gudahtt Gudahtt merged commit 91ffb80 into MetaMask:develop Mar 4, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Mar 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

@danjm danjm Awaiting requested review from danjm

+2 more reviewers

@darkwing darkwing darkwing left review comments

@jacobc-eth jacobc-eth jacobc-eth left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@matteopey @Gudahtt @darkwing @jacobc-eth