This repository was archived by the owner on Oct 22, 2024. It is now read-only.
fix: increase brute force protection TOTP#533
Merged
vinistevam merged 1 commit intomainfrom Feb 21, 2023
Merged
Conversation
917ac87 to
86974e1
Compare
86974e1 to
282fb44
Compare
packages/common/src/utils/totp.ts
Outdated
Contributor
There was a problem hiding this comment.
you could export this const and import it on the test. Just to be sure that both are always in sync
282fb44 to
08b849e
Compare
OGPoyraz
approved these changes
Feb 17, 2023
08b849e to
19a6757
Compare
matthewwalsh0
approved these changes
Feb 20, 2023
19a6757 to
20b0a49
Compare
OGPoyraz
pushed a commit
that referenced
this pull request
Feb 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR aims to increase brute force protection on TOTP setting max attempts within 30 seconds to 5.
Changes
Common
5.Issues
resolves: #522