Skip to content
This repository was archived by the owner on Oct 22, 2024. It is now read-only.

Electron 23 upgrade and tests#526

Merged
bergarces merged 4 commits intomainfrom
chore/electron-upgrade
Feb 21, 2023
Merged

Electron 23 upgrade and tests#526
bergarces merged 4 commits intomainfrom
chore/electron-upgrade

Conversation

@bergarces
Copy link
Copy Markdown
Contributor

@bergarces bergarces commented Feb 14, 2023

No description provided.

@socket-security
Copy link
Copy Markdown

socket-security bot commented Feb 14, 2023 •
edited
Loading

Socket Security Pull Request Report

👍 No new dependency issues detected in pull request

Pull request report summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script confusion ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues
Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@2.4.2

Ignoring: electron@23.1.0

Powered by socket.dev

@bergarces bergarces force-pushed the chore/electron-upgrade branch from 6277acf to 2c91903 Compare February 14, 2023 13:38
@bergarces
Copy link
Copy Markdown
Contributor Author

bergarces commented Feb 14, 2023

@SocketSecurity ignore electron@23.0.0

@bergarces bergarces force-pushed the chore/electron-upgrade branch from 2c91903 to 59b9122 Compare February 14, 2023 13:43
@bergarces bergarces marked this pull request as ready for review February 14, 2023 14:22
@bergarces bergarces requested a review from a team February 14, 2023 14:22
@bergarces bergarces force-pushed the chore/electron-upgrade branch from 06745a9 to 57af587 Compare February 21, 2023 13:10
@bergarces
Copy link
Copy Markdown
Contributor Author

bergarces commented Feb 21, 2023

@SocketSecurity ignore electron@23.1.0

@bergarces bergarces force-pushed the chore/electron-upgrade branch from 4983390 to 920f3fa Compare February 21, 2023 13:53
@bergarces bergarces force-pushed the chore/electron-upgrade branch from 920f3fa to 501116f Compare February 21, 2023 14:31
@bergarces bergarces merged commit b1d9168 into main Feb 21, 2023
OGPoyraz pushed a commit that referenced this pull request Feb 22, 2023
@bergarces @matthewwalsh0 @OGPoyraz
Electron 23 upgrade and tests (#526)
e85e22c 
* chore: electron upgrade

* fix: use node-fetch instead of node 18 fetch

* fix: restore extension commit

* fix: restore commitid submodule

---------

Co-authored-by: Matthew Walsh <matthew.walsh@consensys.net>
@gauthierpetetin gauthierpetetin mentioned this pull request Feb 27, 2023
Closed
@cryptotavares cryptotavares mentioned this pull request Mar 1, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@OGPoyraz OGPoyraz OGPoyraz approved these changes

@matthewwalsh0 matthewwalsh0 matthewwalsh0 approved these changes

@vinistevam vinistevam vinistevam approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bergarces @OGPoyraz @matthewwalsh0 @vinistevam